Re: [PATCHES] [HACKERS] cygwin build failure

2004-11-17 Thread Tom Lane
Reini Urban [EMAIL PROTECTED] writes: I'm just testing a new build from CVS with atttached patch. Patch applied. src/interfaces/ecpg/preproc: the .y and *.l files need to be touched and the generated .c/.h recompiled. They are outdated, at least on CVS. They don't exist in CVS.

Re: [HACKERS] cygwin build failure

2004-11-08 Thread Maarten Boekhold
Hi, Related to the definition of __DLL_IMPORT below, the cygwin port of glib/gmodule just does the following: #define G_MODULE_IMPORT extern #ifdef G_PLATFORM_WIN32 # define G_MODULE_EXPORT __declspec(dllexport) #else /* !G_PLATFORM_WIN32 */ # define G_MODULE_EXPORT

Re: [HACKERS] cygwin build failure

2004-11-07 Thread Reini Urban
Tom Lane schrieb: Dunno about the optarg business; it sounds like a DLLIMPORT is needed someplace, but maybe that is a bug in the Cygwin headers rather than our bug? No, that's no bug, just diagnostic messages with the new linker. gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wendif-labels

Re: [HACKERS] cygwin build failure

2004-11-07 Thread Reini Urban
Reini Urban schrieb: Tom Lane schrieb: Dunno about the optarg business; it sounds like a DLLIMPORT is needed someplace, but maybe that is a bug in the Cygwin headers rather than our bug? No, that's no bug, just diagnostic messages with the new linker. gcc -O2 -Wall -Wmissing-prototypes

Re: [HACKERS] cygwin build failure

2004-11-07 Thread Andrew Dunstan
Reini Urban wrote: ... Info: resolving _optarg by linking to __imp__optarg (auto-import) Info: resolving _optind by linking to __imp__optind (auto-import) ok, i'm sure now. there's no way to ignore those diagnostics on the ld side. It's a minor annoyance at worst. Not worth spending effort

Re: [HACKERS] cygwin build failure

2004-11-07 Thread Bruce Momjian
Andrew Dunstan wrote: Reini Urban wrote: ... Info: resolving _optarg by linking to __imp__optarg (auto-import) Info: resolving _optind by linking to __imp__optind (auto-import) ok, i'm sure now. there's no way to ignore those diagnostics on the ld side. It's a minor

Re: [HACKERS] cygwin build failure

2004-11-07 Thread Bruce Momjian
I am all wrong on the following. It turns out we need a special linker flag on Cygwin to allow the linker to link to the first available symbol in the library (like Unix), and MinGW has a similar flag that we can use to prevent the pg_dump/Makefile hack on MinGW too! Working on a patch now.

Re: [HACKERS] cygwin build failure

2004-11-07 Thread Bruce Momjian
OK, Andrew found the proper flag so Cygwin and MinGW linking will find the first matching library symbol (like Unix) and not error out because of multiple definitions. I have applied the following patch and removed the pg_dump Makefile hack we had before.

Re: [HACKERS] cygwin build failure

2004-11-07 Thread Reini Urban
Bruce Momjian schrieb: OK, Andrew found the proper flag so Cygwin and MinGW linking will find the first matching library symbol (like Unix) and not error out because of multiple definitions. I have applied the following patch and removed the pg_dump Makefile hack we had before.

[HACKERS] cygwin build failure

2004-11-06 Thread Andrew Dunstan
As requested by Reini I set up a Cygwin buildfarm client, and immediately got this build failure: gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wendif-labels -fno-strict-aliasing -g pg_dump.o common.o pg_dump_sort.o pg_backup_archiver.o pg_backup_db.o pg_backup_custom.o pg_backup_files.o

Re: [HACKERS] cygwin build failure

2004-11-06 Thread Bruce Momjian
Andrew Dunstan wrote: As requested by Reini I set up a Cygwin buildfarm client, and immediately got this build failure: gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wendif-labels -fno-strict-aliasing -g pg_dump.o common.o pg_dump_sort.o pg_backup_archiver.o pg_backup_db.o

Re: [HACKERS] cygwin build failure

2004-11-06 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: Andrew Dunstan wrote: /home/adunstan/pgbf/root/HEAD/pgsql.3200/src/port/pgstrcasecmp.c:119: multiple definition of `_pg_tolower' The _pg_tolower problem started when I changed exec.c to use the more standard pg_strcasecmp rather than stricmp. Since