Re: [HACKERS] debug log in pg_archivecleanup

2010-06-18 Thread Simon Riggs
On Thu, 2010-06-17 at 13:33 -0400, Tom Lane wrote: > Fujii Masao writes: > > On Wed, Jun 16, 2010 at 12:24 PM, Takahiro Itagaki > > wrote: > >> This is because pg_archivecleanup puts the line break "\n" in the head of > >> debug message. Why should we do so? > > > Yes. What about the attached pa

Re: [HACKERS] debug log in pg_archivecleanup

2010-06-17 Thread Tom Lane
Fujii Masao writes: > On Wed, Jun 16, 2010 at 12:24 PM, Takahiro Itagaki > wrote: >> This is because pg_archivecleanup puts the line break "\n" in the head of >> debug message. Why should we do so? > Yes. What about the attached patch? Applied along with a bit of further editorialization. >> N

Re: [HACKERS] debug log in pg_archivecleanup

2010-06-16 Thread Fujii Masao
On Wed, Jun 16, 2010 at 12:24 PM, Takahiro Itagaki wrote: > > Fujii Masao wrote: > >> This is because pg_archivecleanup puts the line break "\n" in the head of >> debug message. Why should we do so? >> >> --- >>  if (debug) >>     fprintf(stderr, "\n%s:  removing \"%s\"", prog

Re: [HACKERS] debug log in pg_archivecleanup

2010-06-15 Thread Takahiro Itagaki
Fujii Masao wrote: > This is because pg_archivecleanup puts the line break "\n" in the head of > debug message. Why should we do so? > > --- > if (debug) > fprintf(stderr, "\n%s: removing \"%s\"", progname, WALFilePath); > --- We also need "\n" at

[HACKERS] debug log in pg_archivecleanup

2010-06-15 Thread Fujii Masao
Hi, Sometimes the postgres server log message and the pg_archivecleanup debug message are output in the same line as follows. This is a little hard to read. --- LOG: restored log file "0001006B" from archive pg_archivecleanup: keep WAL file 000100