Re: [HACKERS] double vacuum in initdb

2015-03-31 Thread Bruce Momjian
On Fri, Mar 20, 2015 at 10:59:41PM -0400, Bruce Momjian wrote: > On Thu, Dec 11, 2014 at 08:35:43PM -0500, Peter Eisentraut wrote: > > On 12/11/14 11:44 AM, Kevin Grittner wrote: > > > We want to finish with VACUUM FREEZE without the FULL, unless we > > > don't care about missing visibility maps an

Re: [HACKERS] double vacuum in initdb

2015-03-20 Thread Bruce Momjian
On Thu, Dec 11, 2014 at 08:35:43PM -0500, Peter Eisentraut wrote: > On 12/11/14 11:44 AM, Kevin Grittner wrote: > > We want to finish with VACUUM FREEZE without the FULL, unless we > > don't care about missing visibility maps and free space maps. I have create the attached initdb patch to update t

Re: [HACKERS] double vacuum in initdb

2014-12-11 Thread Peter Eisentraut
On 12/11/14 11:44 AM, Kevin Grittner wrote: > We want to finish with VACUUM FREEZE without the FULL, unless we > don't care about missing visibility maps and free space maps. Why would we care, and if we do, why does VACUUM FULL remove them? You can also run plain VACUUM after FULL to put the map

Re: [HACKERS] double vacuum in initdb

2014-12-11 Thread Robert Haas
On Thu, Dec 11, 2014 at 11:44 AM, Kevin Grittner wrote: > We want to finish with VACUUM FREEZE without the FULL, unless we > don't care about missing visibility maps and free space maps. Oh, good point. I had forgotten about that issue. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com

Re: [HACKERS] double vacuum in initdb

2014-12-11 Thread Kevin Grittner
Tom Lane wrote: > I think we could go to > PG_CMD_PUTS("ANALYZE;\nVACUUM FULL FREEZE;\n"); > > without any degradation of the intended results. > > Another idea would be to drop the FULL part and make this > > PG_CMD_PUTS("ANALYZE;\nVACUUM FREEZE;\n"); We want to finish with VACUUM FREEZE withou

Re: [HACKERS] double vacuum in initdb

2014-12-10 Thread Tom Lane
Peter Eisentraut writes: > initdb currently does > PG_CMD_PUTS("ANALYZE;\nVACUUM FULL;\nVACUUM FREEZE;\n"); > FREEZE is now part of FULL, so this seems redundant. Also, ANALYZE can > be run as part of VACUUM. So this could be > PG_CMD_PUTS("VACUUM FULL ANALYZE;\n"); Merging the ANALYZE

Re: [HACKERS] double vacuum in initdb

2014-12-10 Thread Robert Haas
On Wed, Dec 10, 2014 at 8:50 PM, Peter Eisentraut wrote: > In an unrelated change, use VACUUM FULL; VACUUM FREEZE; rather than > a single VACUUM FULL FREEZE command, to respond to my worries of a > couple days ago about the reliability of doing this in one go. > > That was a long time

[HACKERS] double vacuum in initdb

2014-12-10 Thread Peter Eisentraut
initdb currently does PG_CMD_PUTS("ANALYZE;\nVACUUM FULL;\nVACUUM FREEZE;\n"); FREEZE is now part of FULL, so this seems redundant. Also, ANALYZE can be run as part of VACUUM. So this could be PG_CMD_PUTS("VACUUM FULL ANALYZE;\n"); There has been some concerns about time spent in init