Re: [HACKERS] fillfactor for toast tables is useless?

2009-02-16 Thread ITAGAKI Takahiro
ITAGAKI Takahiro itagaki.takah...@oss.ntt.co.jp wrote: The attached is a patch to change 3 things: - Reject toast.fillfactor. - Modify relopt_kind to bit flags. - Report relation type on unrecognized parameter errors. I registered the patch as an open item:

Re: [HACKERS] fillfactor for toast tables is useless?

2009-02-12 Thread Alvaro Herrera
ITAGAKI Takahiro wrote: With reloption patch, we can set WITH options to toast tables. However, fillfactor for toast tables is useless, no? Maybe what we should do is just reject fillfactor for toast tables for now. I think this is easy to do. -- Alvaro Herrera

Re: [HACKERS] fillfactor for toast tables is useless?

2009-02-12 Thread ITAGAKI Takahiro
Alvaro Herrera alvhe...@commandprompt.com wrote: ITAGAKI Takahiro wrote: With reloption patch, we can set WITH options to toast tables. However, fillfactor for toast tables is useless, no? Maybe what we should do is just reject fillfactor for toast tables for now. I think this is easy

[HACKERS] fillfactor for toast tables is useless?

2009-02-11 Thread ITAGAKI Takahiro
With reloption patch, we can set WITH options to toast tables. However, fillfactor for toast tables is useless, no? (autovacuum options will work as expected, though.) Tuples in toast tables are never updated. When the main tuple is updated, old toast tuples are deleted and new ones are inserted.