Re: [HACKERS] fillfactor using WITH syntax

2006-06-06 Thread ITAGAKI Takahiro
Simon Riggs <[EMAIL PROTECTED]> wrote: > Itagaki had suggested adding options to heaps also, so clearly we'd need > to add that to pg_class, rather than pg_index in that case. Yes, I want to add options tables not only indexes. There is pg_index for indexes, but is not pg_table for tables, so I ad

Re: [HACKERS] fillfactor using WITH syntax

2006-06-06 Thread Simon Riggs
On Tue, 2006-06-06 at 10:27 -0400, Tom Lane wrote: > Simon Riggs <[EMAIL PROTECTED]> writes: > > Why not implement an array of option parameters on pg_class, so both > > heaps and indexes can be given additional parameters? That way you > > wouldn't need a specific relfillfactor attribute. That wou

Re: [HACKERS] fillfactor using WITH syntax

2006-06-06 Thread Tom Lane
Simon Riggs <[EMAIL PROTECTED]> writes: > Why not implement an array of option parameters on pg_class, so both > heaps and indexes can be given additional parameters? That way you > wouldn't need a specific relfillfactor attribute. That would allow us to > keep CREATE TABLE free of additional keywo

Re: [HACKERS] fillfactor using WITH syntax

2006-06-06 Thread Simon Riggs
On Tue, 2006-06-06 at 11:45 +0900, ITAGAKI Takahiro wrote: > Hi Hackers, > > I'm rewriting fillfactor patch, per the following discussion, > http://archives.postgresql.org/pgsql-hackers/2006-03/msg00287.php > Now fillfactor can be set using WITH syntax: > - CREATE INDEX index ON table USING

Re: [HACKERS] fillfactor using WITH syntax

2006-06-05 Thread Tom Lane
ITAGAKI Takahiro <[EMAIL PROTECTED]> writes: > Now, I want to ask you how to modify WITH parameters for existing > tables/indexes. I'd go with the ALTER TABLE, rather than cluttering N other commands. There's already precedent for delayed effects of parameter alterations (SET, ALTER SET STATISTICS

[HACKERS] fillfactor using WITH syntax

2006-06-05 Thread ITAGAKI Takahiro
Hi Hackers, I'm rewriting fillfactor patch, per the following discussion, http://archives.postgresql.org/pgsql-hackers/2006-03/msg00287.php Now fillfactor can be set using WITH syntax: - CREATE INDEX index ON table USING btree (columns) WITH (...) - CREATE TABLE table (i integer PRIMARY KE