Re: [HACKERS] fix worker_spi to run as non-dynamic background worker

2014-05-29 Thread Robert Haas
On Tue, May 27, 2014 at 12:11 AM, Michael Paquier wrote: > The feature itself is already mentioned in the release notes in a very > general manner, by telling that bgworkers can be dynamically > "registered" and "started". Users can still refer to the documentation > to see more precisely what kin

Re: [HACKERS] fix worker_spi to run as non-dynamic background worker

2014-05-26 Thread Michael Paquier
On Tue, May 27, 2014 at 12:09 PM, Robert Haas wrote: > On Fri, May 23, 2014 at 10:38 AM, Michael Paquier > wrote: >> On Fri, May 23, 2014 at 6:29 PM, Shigeru Hanada >> wrote: >>> I noticed that contrib/worker_spi can't run as non-dynamic background >>> worker (IOW, load via shared_preload_librar

Re: [HACKERS] fix worker_spi to run as non-dynamic background worker

2014-05-26 Thread Robert Haas
On Fri, May 23, 2014 at 10:38 AM, Michael Paquier wrote: > On Fri, May 23, 2014 at 6:29 PM, Shigeru Hanada > wrote: >> I noticed that contrib/worker_spi can't run as non-dynamic background >> worker (IOW, load via shared_preload_libraries), because of >> uninitialized bgw_notify_pid. > That's act

Re: [HACKERS] fix worker_spi to run as non-dynamic background worker

2014-05-26 Thread Robert Haas
On Fri, May 23, 2014 at 5:29 AM, Shigeru Hanada wrote: > I noticed that contrib/worker_spi can't run as non-dynamic background > worker (IOW, load via shared_preload_libraries), because of > uninitialized bgw_notify_pid. > > Attached patch fixes this issue. Please apply onto HEAD and 9.4. Good c

Re: [HACKERS] fix worker_spi to run as non-dynamic background worker

2014-05-23 Thread Michael Paquier
On Fri, May 23, 2014 at 6:29 PM, Shigeru Hanada wrote: > I noticed that contrib/worker_spi can't run as non-dynamic background > worker (IOW, load via shared_preload_libraries), because of > uninitialized bgw_notify_pid. That's actually the case of all the bgworkers that have been developed with 9

[HACKERS] fix worker_spi to run as non-dynamic background worker

2014-05-23 Thread Shigeru Hanada
Hi all, I noticed that contrib/worker_spi can't run as non-dynamic background worker (IOW, load via shared_preload_libraries), because of uninitialized bgw_notify_pid. I got log lines below when starting PostgreSQL with shared_preload_libraries = 'worker_spi'. $ pg_ctl start -w waiting for serve