Re: [HACKERS] fixing pg_upgrade strings (was Re: pgsql: Add new files to nls.mk and add translation)

2017-08-02 Thread Tom Lane
Alvaro Herrera writes: > It does this: > pg_fatal("You must identify the directory where the %s.\n" > "Please use the %s command-line option or the %s > environment variable.\n", > description, cmdLineOption, envVarName); > and the callsites

[HACKERS] fixing pg_upgrade strings (was Re: pgsql: Add new files to nls.mk and add translation)

2017-08-02 Thread Alvaro Herrera
Peter Eisentraut wrote: > Add new files to nls.mk and add translation markers This reminds me that I noticed a few days ago another really serious broken piece in pg_upgrade where check_required_directory() is incurring in the ugliest case of string building I've ever seen. I didn't have the cour