Re: [HACKERS] hba load error and silent mode

2009-08-24 Thread Tom Lane
Magnus Hagander writes: > On Mon, Aug 24, 2009 at 20:51, Andrew Dunstan wrote: >> We didn't check HBA validity at startup time before, did we? I would not be >> surprised to get more complaints now. Good point. > We checked some of it, but we check it a whole lot more now. > +1 for backpatching

Re: [HACKERS] hba load error and silent mode

2009-08-24 Thread Magnus Hagander
On Mon, Aug 24, 2009 at 20:51, Andrew Dunstan wrote: > > > Tom Lane wrote: >> >> Andrew Dunstan writes: >> >>> >>> Tom Lane wrote: >>> Oh, you mean move load_hba *down*, past the syslogger startup? Yeah, that would probably be all right. >> >> >>> >>> Well, that's what I origin

Re: [HACKERS] hba load error and silent mode

2009-08-24 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan writes: Tom Lane wrote: Oh, you mean move load_hba *down*, past the syslogger startup? Yeah, that would probably be all right. Well, that's what I originally said, yes ;-) But I don't think that precludes your more general suggest

Re: [HACKERS] hba load error and silent mode

2009-08-24 Thread Tom Lane
Andrew Dunstan writes: > Tom Lane wrote: >> Oh, you mean move load_hba *down*, past the syslogger startup? >> Yeah, that would probably be all right. > Well, that's what I originally said, yes ;-) > But I don't think that precludes your more general suggestion regarding > startup errors. In par

Re: [HACKERS] hba load error and silent mode

2009-08-24 Thread Andrew Dunstan
Tom Lane wrote: Magnus Hagander writes: I don't see why we couldn't move the hba call specifically, though. That's a fairly common error, so it would be good if the output went to the place that is actually configured in postgresql.conf. It's at least a lot more likely than most other thin

Re: [HACKERS] hba load error and silent mode

2009-08-24 Thread Tom Lane
Magnus Hagander writes: > I don't see why we couldn't move the hba call specifically, though. > That's a fairly common error, so it would be good if the output went > to the place that is actually configured in postgresql.conf. It's at > least a lot more likely than most other things that are prio

Re: [HACKERS] hba load error and silent mode

2009-08-24 Thread Magnus Hagander
On Mon, Aug 24, 2009 at 16:31, Tom Lane wrote: > Andrew Dunstan writes: >> (Maybe there's a good case for deprecating silent mode. > > +1.  The only reason to use it is that an init-script writer is too > lazy to deal with things properly --- the thing in question here being > exactly to think of

Re: [HACKERS] hba load error and silent mode

2009-08-24 Thread Tom Lane
Andrew Dunstan writes: > Tom Lane wrote: >> It might be that a reasonable solution on our end would be for >> pmdaemonize to point stdout/stderr someplace other than /dev/null, >> perhaps "$PGDATA/postmaster.log"? Of course, it's not clear what >> we're supposed to do if that open() fails ... >

Re: [HACKERS] hba load error and silent mode

2009-08-24 Thread Andrew Dunstan
Tom Lane wrote: It might be that a reasonable solution on our end would be for pmdaemonize to point stdout/stderr someplace other than /dev/null, perhaps "$PGDATA/postmaster.log"? Of course, it's not clear what we're supposed to do if that open() fails ... Well, yes, but

Re: [HACKERS] hba load error and silent mode

2009-08-24 Thread Tom Lane
Andrew Dunstan writes: > (Maybe there's a good case for deprecating silent mode. +1. The only reason to use it is that an init-script writer is too lazy to deal with things properly --- the thing in question here being exactly to think of a place for early failure messages to go. You can *not*

Re: [HACKERS] hba load error and silent mode

2009-08-24 Thread Joshua Tolley
On Mon, Aug 24, 2009 at 02:57:02PM +0200, Magnus Hagander wrote: > On Mon, Aug 24, 2009 at 14:39, Andrew Dunstan wrote: > > > > Last night I had to deal with a puzzled user of version 8.4  who found > > postgres refused to start but didn't log any error.  It turned out that > > there was an error i

Re: [HACKERS] hba load error and silent mode

2009-08-24 Thread Andrew Dunstan
Magnus Hagander wrote: (Maybe there's a good case for deprecating silent mode. I'm not sure why Suse uses it. Other distros don't seem to feel the need.) Could be, but even with silent_mode=off that would be a problem, no? as in, the log wouldn't go where you'd expect it to go. It

Re: [HACKERS] hba load error and silent mode

2009-08-24 Thread Magnus Hagander
On Mon, Aug 24, 2009 at 14:39, Andrew Dunstan wrote: > > Last night I had to deal with a puzzled user of version 8.4  who found > postgres refused to start but didn't log any error.  It turned out that > there was an error in the pg_hba.conf file, and the client was running in > silent mode (the SU

[HACKERS] hba load error and silent mode

2009-08-24 Thread Andrew Dunstan
Last night I had to deal with a puzzled user of version 8.4 who found postgres refused to start but didn't log any error. It turned out that there was an error in the pg_hba.conf file, and the client was running in silent mode (the SUSE default). This seems like a bug, and it's certainly n