Re: [HACKERS] incorrect docs for pgbench / skipped transactions

2016-03-29 Thread Fabien COELHO
Please split the patch into one part for backporting and one part for master-only and post both patches, clearly indicating which is which. Attached are the full patch for head and the backport part (the patch name ends with "backport") separated. That's not really what I wanted; the full p

Re: [HACKERS] incorrect docs for pgbench / skipped transactions

2016-03-29 Thread Robert Haas
On Mon, Mar 21, 2016 at 2:32 PM, Fabien COELHO wrote: >>> Ok, I added a reference to the commitfest entry from this wiki page, and >>> a >>> note about partial 9.5 backporting. >> >> Please split the patch into one part for backporting and one part for >> master-only and post both patches, clearly

Re: [HACKERS] incorrect docs for pgbench / skipped transactions

2016-03-21 Thread Fabien COELHO
Ok, I added a reference to the commitfest entry from this wiki page, and a note about partial 9.5 backporting. Please split the patch into one part for backporting and one part for master-only and post both patches, clearly indicating which is which. Attached are the full patch for head and

Re: [HACKERS] incorrect docs for pgbench / skipped transactions

2016-03-21 Thread Robert Haas
On Sat, Mar 19, 2016 at 3:28 PM, Fabien COELHO wrote: >>> Thanks for the pointer. However, I do not have "editor priviledge" on >>> this >>> wiki, maybe Tomas has? >> >> I gave you editor privs now, but since it's in 9.5 I guess it needs to >> be on the bug tracker (Except, of course, we don't hav

Re: [HACKERS] incorrect docs for pgbench / skipped transactions

2016-03-19 Thread Alvaro Herrera
Fabien COELHO wrote: > > >>I've created an entry in the next commit fest so that it is not lost, but I > >>hope it will be committed before then. > > > >If this problem was introduced by commits in 9.6, this issue should be > >listed in the open items page, > >https://wiki.postgresql.org/wiki/Open

Re: [HACKERS] incorrect docs for pgbench / skipped transactions

2016-03-19 Thread Fabien COELHO
Thanks for the pointer. However, I do not have "editor priviledge" on this wiki, maybe Tomas has? I gave you editor privs now, but since it's in 9.5 I guess it needs to be on the bug tracker (Except, of course, we don't have one.) Ok, I added a reference to the commitfest entry from this wi

Re: [HACKERS] incorrect docs for pgbench / skipped transactions

2016-03-19 Thread Fabien COELHO
I've created an entry in the next commit fest so that it is not lost, but I hope it will be committed before then. If this problem was introduced by commits in 9.6, this issue should be listed in the open items page, https://wiki.postgresql.org/wiki/Open_Items Thanks for the pointer. However

Re: [HACKERS] incorrect docs for pgbench / skipped transactions

2016-03-19 Thread Alvaro Herrera
Fabien COELHO wrote: > > I've created an entry in the next commit fest so that it is not lost, but I > hope it will be committed before then. If this problem was introduced by commits in 9.6, this issue should be listed in the open items page, https://wiki.postgresql.org/wiki/Open_Items -- Álva

Re: [HACKERS] incorrect docs for pgbench / skipped transactions

2016-03-19 Thread Fabien COELHO
I've created an entry in the next commit fest so that it is not lost, but I hope it will be committed before then. -- Fabien. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] incorrect docs for pgbench / skipped transactions

2016-03-19 Thread Tomas Vondra
Hi, On 03/19/2016 08:29 AM, Fabien COELHO wrote: ... Here is an updated version of your proposal: - use instead of " - use script_no and mention -b as well - spell out skipped explanation after the sample output Seems fine to me. Also, while reading the doc, I really think that the

Re: [HACKERS] incorrect docs for pgbench / skipped transactions

2016-03-19 Thread Fabien COELHO
Hello Tomas, while learning about format of the transaction log produced by pgbench, I've noticed this sentence in the section describing format of the per-transaction log: The last field skipped_transactions reports the number of transactions skipped because they were too far behind sch

[HACKERS] incorrect docs for pgbench / skipped transactions

2016-03-18 Thread Tomas Vondra
Hi, while learning about format of the transaction log produced by pgbench, I've noticed this sentence in the section describing format of the per-transaction log: The last field skipped_transactions reports the number of transactions skipped because they were too far behind schedule.