Re: [HACKERS] increase message string buffer size of watch command of psql

2016-06-15 Thread Ioseph Kim
Thanks, I agree that strftime() is better then asctime(). regards, Ioseph 2016년 06월 16일 08:37에 Tom Lane 이(가) 쓴 글: > Alvaro Herrera writes: >> +1 to strftime("%c"). If we wanted to provide additional flexibility we >> could have a \pset option to change the strftime

Re: [HACKERS] increase message string buffer size of watch command of psql

2016-06-15 Thread Tom Lane
Alvaro Herrera writes: > +1 to strftime("%c"). If we wanted to provide additional flexibility we > could have a \pset option to change the strftime format string to > something other than %c, but I don't think there's enough demand to > justify it. Agreed, that seems

Re: [HACKERS] increase message string buffer size of watch command of psql

2016-06-15 Thread Alvaro Herrera
Tom Lane wrote: > I wrote: > > Well, we did part of that, but it's still using asctime(). Should we > > change that to strftime(..."%c"...) to be less English-centric? > > (The result seems to be the same in C locale. pg_controldata has done > > it that way for a long time, with few

Re: [HACKERS] increase message string buffer size of watch command of psql

2016-06-14 Thread Tom Lane
Ioseph Kim writes: > 2016년 06월 15일 01:56에 Tom Lane 이(가) 쓴 글: >> I take it from the vast silence that nobody particularly cares one way >> or the other. On reflection I think that this would be a good change >> to make, so I'll go do so unless I hear

Re: [HACKERS] increase message string buffer size of watch command of psql

2016-06-14 Thread Ioseph Kim
2016년 06월 15일 01:56에 Tom Lane 이(가) 쓴 글: I take it from the vast silence that nobody particularly cares one way or the other. On reflection I think that this would be a good change to make, so I'll go do so unless I hear complaints soon. regards, tom lane I propose to change from asctime()

Re: [HACKERS] increase message string buffer size of watch command of psql

2016-06-14 Thread Tom Lane
I wrote: > Robert Haas writes: >> On Sun, Jun 12, 2016 at 10:55 AM, Ioseph Kim wrote: >>> Increase size of this title, please. >>> 50 bytes is so small for multi language. >>> And. I suggest that date string might be local language, >>> or

Re: [HACKERS] increase message string buffer size of watch command of psql

2016-06-12 Thread Tom Lane
Robert Haas writes: > On Sun, Jun 12, 2016 at 10:55 AM, Ioseph Kim wrote: >> Increase size of this title, please. >> 50 bytes is so small for multi language. >> >> And. I suggest that date string might be local language, >> or current_timestamp

Re: [HACKERS] increase message string buffer size of watch command of psql

2016-06-12 Thread Robert Haas
On Sun, Jun 12, 2016 at 10:55 AM, Ioseph Kim wrote: > Hello. > In po.ko (korean message) at psql > #: command.c:2971 > #, c-format > msgid "Watch every %lds\t%s" > msgstr "%ld초 간격으로 지켜보기\t%s" > > this message string is a cut string, because buffer size is small. > At line

[HACKERS] increase message string buffer size of watch command of psql

2016-06-12 Thread Ioseph Kim
Hello. In po.ko (korean message) at psql #: command.c:2971 #, c-format msgid "Watch every %lds\t%s" msgstr "%ld초 간격으로 지켜보기\t%s" this message string is a cut string, because buffer size is small. At line 2946 in src/bin/psql/command.c chartitle[50]; size of message string for korean