Re: [HACKERS] initdb mkdir_p() doesn't work

2003-12-01 Thread Bruce Momjian
Patch applied. Thanks. --- Andrew Dunstan wrote: > > > Andrew Dunstan wrote: > > > > > > > Peter Eisentraut wrote: > > > >> Here is what I get: > >> > >> peter ~$ pg-install/bin/initdb pg-install/var/data > >> ... > >>

Re: [HACKERS] initdb mkdir_p() doesn't work

2003-11-29 Thread Bruce Momjian
Tom Lane wrote: > Andrew Dunstan <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> AFAICS mkdatadir() shouldn't consider subdir == NULL as a reason to > >> fail rather than trying mkdir_p. > > > Right. In fact, I can't see any good reason to call mkdir and then > > mkdir_p at all. See my patch

Re: [HACKERS] initdb mkdir_p() doesn't work

2003-11-29 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches I will try to apply it within the next 48 hours. --- Andrew Dunstan wrote: > > > Andrew Duns

Re: [HACKERS] initdb mkdir_p() doesn't work

2003-11-23 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan <[EMAIL PROTECTED]> writes: Tom Lane wrote: AFAICS mkdatadir() shouldn't consider subdir == NULL as a reason to fail rather than trying mkdir_p. Right. In fact, I can't see any good reason to call mkdir and then mkdir_p at all. See my patch from

Re: [HACKERS] initdb mkdir_p() doesn't work

2003-11-23 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> AFAICS mkdatadir() shouldn't consider subdir == NULL as a reason to >> fail rather than trying mkdir_p. > Right. In fact, I can't see any good reason to call mkdir and then > mkdir_p at all. See my patch from this afternoon. I'm uns

Re: [HACKERS] initdb mkdir_p() doesn't work

2003-11-23 Thread Andrew Dunstan
Tom Lane wrote: AFAICS mkdatadir() shouldn't consider subdir == NULL as a reason to fail rather than trying mkdir_p. Indeed, if anything the opposite: when subdir isn't NULL the immediately prior directory level should exist already. Right. In fact, I can't see any good reason to call mkdir and

Re: [HACKERS] initdb mkdir_p() doesn't work

2003-11-23 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > Peter Eisentraut wrote: >> creating directory pg-install/var/data ... initdb: failed > I will check it out. I know I spent quite some time making sure this > worked, but I might have missed something obvious. I wonder if it is > platform specific? AF

Re: [HACKERS] initdb mkdir_p() doesn't work

2003-11-23 Thread Andrew Dunstan
Andrew Dunstan wrote: Peter Eisentraut wrote: Here is what I get: peter ~$ pg-install/bin/initdb pg-install/var/data ... creating directory pg-install/var/data ... initdb: failed No points for details in the error message here either. If I create pg-install/var first, then it work. I will

Re: [HACKERS] initdb mkdir_p() doesn't work

2003-11-23 Thread Andrew Dunstan
Peter Eisentraut wrote: Here is what I get: peter ~$ pg-install/bin/initdb pg-install/var/data ... creating directory pg-install/var/data ... initdb: failed No points for details in the error message here either. If I create pg-install/var first, then it work. I will check it out. I know I sp

[HACKERS] initdb mkdir_p() doesn't work

2003-11-23 Thread Peter Eisentraut
Here is what I get: peter ~$ pg-install/bin/initdb pg-install/var/data ... creating directory pg-install/var/data ... initdb: failed No points for details in the error message here either. If I create pg-install/var first, then it work. -- Peter Eisentraut [EMAIL PROTECTED] ---