Re: [HACKERS] jsonb failed assertions

2014-05-28 Thread Heikki Linnakangas
On 05/28/2014 04:13 AM, Peter Geoghegan wrote: On Wed, May 21, 2014 at 4:53 AM, Heikki Linnakangas wrote: Hmm. The patch looks correct as far as it goes. But that function is still a bit funny. When it compares two identical arrays (or objects), and reaches the WJB_END_ARRAY token, it will stil

Re: [HACKERS] jsonb failed assertions

2014-05-27 Thread Peter Geoghegan
On Wed, May 21, 2014 at 4:53 AM, Heikki Linnakangas wrote: > Hmm. The patch looks correct as far as it goes. But that function is still a > bit funny. When it compares two identical arrays (or objects), and reaches > the WJB_END_ARRAY token, it will still fall into the code that checks what > the

Re: [HACKERS] jsonb failed assertions

2014-05-21 Thread Heikki Linnakangas
On 05/20/2014 09:22 PM, Peter Geoghegan wrote: On Tue, May 20, 2014 at 4:17 PM, Pavel Stehule wrote: table dump is downloadable from http://pgsql.cz/data/data.dump.gz This looks like an over-zealous assertion, without any user-visible consequences. Mea culpa. Attached patch corrects the prob

Re: [HACKERS] jsonb failed assertions

2014-05-20 Thread Pavel Stehule
2014-05-21 3:22 GMT+02:00 Peter Geoghegan : > On Tue, May 20, 2014 at 4:17 PM, Pavel Stehule > wrote: > > table dump is downloadable from http://pgsql.cz/data/data.dump.gz > > This looks like an over-zealous assertion, without any user-visible > consequences. Mea culpa. > > Attached patch correct

Re: [HACKERS] jsonb failed assertions

2014-05-20 Thread Peter Geoghegan
On Tue, May 20, 2014 at 4:17 PM, Pavel Stehule wrote: > table dump is downloadable from http://pgsql.cz/data/data.dump.gz This looks like an over-zealous assertion, without any user-visible consequences. Mea culpa. Attached patch corrects the problem. I also noticed in passing that there is ano

Re: [HACKERS] jsonb failed assertions

2014-05-20 Thread Pavel Stehule
2014-05-20 21:45 GMT+02:00 Peter Geoghegan : > On Tue, May 20, 2014 at 12:38 PM, Pavel Stehule > wrote: > > NOTICE: a:>> {"type": "Feature", "geometry": null, "properties": > {"TO_ST": > > null, "BLKLOT": "1245063", "STREET": null, "FROM_ST": null, "LOT_NUM": > > "063", "ST_TYPE": null, "ODD_EVE

Re: [HACKERS] jsonb failed assertions

2014-05-20 Thread Peter Geoghegan
On Tue, May 20, 2014 at 12:38 PM, Pavel Stehule wrote: > NOTICE: a:>> {"type": "Feature", "geometry": null, "properties": {"TO_ST": > null, "BLKLOT": "1245063", "STREET": null, "FROM_ST": null, "LOT_NUM": > "063", "ST_TYPE": null, "ODD_EVEN": null, "BLOCK_NUM": "1245", "MAPBLKLOT": > "1245061"}}<

Re: [HACKERS] jsonb failed assertions

2014-05-20 Thread Pavel Stehule
NOTICE: a:>> {"type": "Feature", "geometry": null, "properties": {"TO_ST": null, "BLKLOT": "1245063", "STREET": null, "FROM_ST": null, "LOT_NUM": "063", "ST_TYPE": null, "ODD_EVEN": null, "BLOCK_NUM": "1245", "MAPBLKLOT": "1245061"}}<<< NOTICE: b:>> {"type": "Feature", "geometry": {"type": "Polyg

Re: [HACKERS] jsonb failed assertions

2014-05-20 Thread Peter Geoghegan
On Tue, May 20, 2014 at 12:03 PM, Pavel Stehule wrote: > va.type is zero .. jbvNull Thanks...any luck with identifying the two JSON documents? -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql

Re: [HACKERS] jsonb failed assertions

2014-05-20 Thread Pavel Stehule
2014-05-20 20:40 GMT+02:00 Peter Geoghegan : > On Tue, May 20, 2014 at 11:23 AM, Pavel Stehule > wrote: > > TRAP: FailedAssertion("!(va.type == jbvArray || va.type == jbvObject)", > > File: "jsonb_util.c", Line: 208) > > So, what type is va.type, if not one of those two? > va.type is zero .. jbv

Re: [HACKERS] jsonb failed assertions

2014-05-20 Thread Peter Geoghegan
On Tue, May 20, 2014 at 11:40 AM, Peter Geoghegan wrote: > > So, what type is va.type, if not one of those two? You should be able to figure out which pair of JSON documents are being compared by printing JsonbIterator.dataProper within GDB (that is, you should do so for both ita and itb within c

Re: [HACKERS] jsonb failed assertions

2014-05-20 Thread Peter Geoghegan
On Tue, May 20, 2014 at 11:23 AM, Pavel Stehule wrote: > TRAP: FailedAssertion("!(va.type == jbvArray || va.type == jbvObject)", > File: "jsonb_util.c", Line: 208) So, what type is va.type, if not one of those two? -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@post

[HACKERS] jsonb failed assertions

2014-05-20 Thread Pavel Stehule
Hello I created relative large (about 200K lines) simple table (one jsonb column): It works, but I got a errors: TRAP: FailedAssertion("!(va.type == jbvArray || va.type == jbvObject)", File: "jsonb_util.c", Line: 208) LOG: server process (PID 3851) was terminated by signal 6: Aborted DETAIL: F