Re: [HACKERS] log_checkpoints and restartpoint

2011-02-02 Thread Robert Haas
On Wed, Feb 2, 2011 at 8:16 PM, Itagaki Takahiro wrote: > On Mon, Jan 31, 2011 at 05:17, Robert Haas wrote: >>> The attached patch changes LogCheckpointEnd so that it logs >>> the number of WAL files created/deleted/recycled even in >>> restartpoint. >> >> This patch looks good to me.  For now, I

Re: [HACKERS] log_checkpoints and restartpoint

2011-02-02 Thread Itagaki Takahiro
On Mon, Jan 31, 2011 at 05:17, Robert Haas wrote: >> The attached patch changes LogCheckpointEnd so that it logs >> the number of WAL files created/deleted/recycled even in >> restartpoint. > > This patch looks good to me.  For now, I'm marking it Ready for > Committer.  Absent objections, I will

Re: [HACKERS] log_checkpoints and restartpoint

2011-01-30 Thread Robert Haas
On Tue, Jan 25, 2011 at 11:14 PM, Fujii Masao wrote: > When log_checkpoints is enabled, checkpoint logs the number of > WAL files created/deleted/recycled, but restartpoint doesn't. > This is OK before 9.0 because restartpoint had never created/ > deleted/recycled WAL files. But, in 9.0 or later,

Re: [HACKERS] log_checkpoints and restartpoint

2011-01-26 Thread Fujii Masao
On Wed, Jan 26, 2011 at 7:59 PM, Simon Riggs wrote: > On Wed, 2011-01-26 at 13:14 +0900, Fujii Masao wrote: > >> When log_checkpoints is enabled, checkpoint logs the number of >> WAL files created/deleted/recycled, but restartpoint doesn't. >> This is OK before 9.0 because restartpoint had never c

Re: [HACKERS] log_checkpoints and restartpoint

2011-01-26 Thread Simon Riggs
On Wed, 2011-01-26 at 13:14 +0900, Fujii Masao wrote: > When log_checkpoints is enabled, checkpoint logs the number of > WAL files created/deleted/recycled, but restartpoint doesn't. > This is OK before 9.0 because restartpoint had never created/ > deleted/recycled WAL files. But, in 9.0 or later,

[HACKERS] log_checkpoints and restartpoint

2011-01-25 Thread Fujii Masao
Hi, When log_checkpoints is enabled, checkpoint logs the number of WAL files created/deleted/recycled, but restartpoint doesn't. This is OK before 9.0 because restartpoint had never created/ deleted/recycled WAL files. But, in 9.0 or later, restartpoint might do that while walreceiver is running.