Re: [HACKERS] log_error_verbosity function display

2010-02-12 Thread Bruce Momjian
Robert Haas wrote: > On Thu, Feb 11, 2010 at 5:47 PM, Bruce Momjian wrote: > > Tom Lane wrote: > >> Bruce Momjian writes: > >> > Jaime Casanova wrote: > >> >> i like this with or without the (), but maybe we are breaking client > >> >> apps if change that > >> > >> > Ah, so you like FUNCTION. > >

Re: [HACKERS] log_error_verbosity function display

2010-02-11 Thread Robert Haas
On Thu, Feb 11, 2010 at 5:47 PM, Bruce Momjian wrote: > Tom Lane wrote: >> Bruce Momjian writes: >> > Jaime Casanova wrote: >> >> i like this with or without the (), but maybe we are breaking client >> >> apps if change that >> >> > Ah, so you like FUNCTION. >> >> You can NOT change the line tag

Re: [HACKERS] log_error_verbosity function display

2010-02-11 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > Jaime Casanova wrote: > >> i like this with or without the (), but maybe we are breaking client > >> apps if change that > > > Ah, so you like FUNCTION. > > You can NOT change the line tag without almost certainly breaking > log-reading tools like pgfo

Re: [HACKERS] log_error_verbosity function display

2010-02-11 Thread Tom Lane
Bruce Momjian writes: > Jaime Casanova wrote: >> i like this with or without the (), but maybe we are breaking client >> apps if change that > Ah, so you like FUNCTION. You can NOT change the line tag without almost certainly breaking log-reading tools like pgfouine. Even changing the content o

Re: [HACKERS] log_error_verbosity function display

2010-02-11 Thread Robert Haas
On Thu, Feb 11, 2010 at 2:08 PM, Alvaro Herrera wrote: > Bruce Momjian wrote: > >> FYI, here is the output that had me confused: >> >>       ERROR:  42P01: relation "lkjasdf" does not exist at character 15 >>       LOCATION:  parserOpenTable, parse_relation.c:858 >>       STATEMENT:  select * from

Re: [HACKERS] log_error_verbosity function display

2010-02-11 Thread Bruce Momjian
Jaime Casanova wrote: > On Thu, Feb 11, 2010 at 6:03 AM, Bruce Momjian wrote: > > > > Of course, maybe the word LOCATION is wrong and it should be FUNCTION: > > > > ? ? ? ?ERROR: ?42P01: relation "lkjasdf" does not exist at character 15 > > ? ? ? ?FUNCTION: ?parserOpenTable(), parse_relation.c:858

Re: [HACKERS] log_error_verbosity function display

2010-02-11 Thread Bruce Momjian
Alvaro Herrera wrote: > Bruce Momjian wrote: > > > FYI, here is the output that had me confused: > > > > ERROR: 42P01: relation "lkjasdf" does not exist at character 15 > > LOCATION: parserOpenTable, parse_relation.c:858 > > STATEMENT: select * from lkjasdf; > > How about somethin

Re: [HACKERS] log_error_verbosity function display

2010-02-11 Thread Jaime Casanova
On Thu, Feb 11, 2010 at 6:03 AM, Bruce Momjian wrote: > > Of course, maybe the word LOCATION is wrong and it should be FUNCTION: > >        ERROR:  42P01: relation "lkjasdf" does not exist at character 15 >        FUNCTION:  parserOpenTable(), parse_relation.c:858 >        STATEMENT:  select * fro

Re: [HACKERS] log_error_verbosity function display

2010-02-11 Thread Alvaro Herrera
Bruce Momjian wrote: > FYI, here is the output that had me confused: > > ERROR: 42P01: relation "lkjasdf" does not exist at character 15 > LOCATION: parserOpenTable, parse_relation.c:858 > STATEMENT: select * from lkjasdf; How about something like ERROR: 42P01: relation "l

Re: [HACKERS] log_error_verbosity function display

2010-02-11 Thread Bruce Momjian
Bruce Momjian wrote: > Tom Lane wrote: > > Bruce Momjian writes: > > > Right now, log_error_verbosity displays the source code error location > > > in this format: > > > > > LOCATION: parserOpenTable, parse_relation.c:858 > > > > > I think it would be clearer to add '()' next to the function

Re: [HACKERS] log_error_verbosity function display

2010-02-10 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > Right now, log_error_verbosity displays the source code error location > > in this format: > > > LOCATION: parserOpenTable, parse_relation.c:858 > > > I think it would be clearer to add '()' next to the function name. We > > use '() to display fu

Re: [HACKERS] log_error_verbosity function display

2010-02-10 Thread Tom Lane
Bruce Momjian writes: > Right now, log_error_verbosity displays the source code error location > in this format: > LOCATION: parserOpenTable, parse_relation.c:858 > I think it would be clearer to add '()' next to the function name. We > use '() to display function names in our docs and I

[HACKERS] log_error_verbosity function display

2010-02-10 Thread Bruce Momjian
Right now, log_error_verbosity displays the source code error location in this format: LOCATION: parserOpenTable, parse_relation.c:858 I think it would be clearer to add '()' next to the function name. We use '() to display function names in our docs and I think using '()' would clarify