Re: [HACKERS] log_statement and Parse/Bind

2004-05-25 Thread Oliver Jowett
Tom Lane wrote: Oliver Jowett <[EMAIL PROTECTED]> writes: I notice that when using the extended query protocol, statement logging appears to happen only when a Parse message is received. This is less than ideal: I agree, but I didn't have time at the end of the 7.4 development cycle to work out

Re: [HACKERS] log_statement and Parse/Bind

2004-05-24 Thread Tom Lane
Oliver Jowett <[EMAIL PROTECTED]> writes: > I notice that when using the extended query protocol, statement logging > appears to happen only when a Parse message is received. This is less > than ideal: I agree, but I didn't have time at the end of the 7.4 development cycle to work out what shoul

Re: [HACKERS] log_statement and Parse/Bind

2004-05-24 Thread Bruce Momjian
Oliver Jowett wrote: > I notice that when using the extended query protocol, statement logging > appears to happen only when a Parse message is received. This is less > than ideal: > > - statements can be logged that are not actually executed (i.e. a > Parse/Bind with no corresponding Execute).

Re: [HACKERS] log_statement and Parse/Bind

2004-05-24 Thread Oliver Jowett
Bruce Momjian wrote: Well, at execute time, we don't have easy access to the original prepare statement, especially at that stage in the code. Do you see anyway to improve that? We have portal->sourceText which looks like it should contain the original query. (note that I'm talking about the V3 p

[HACKERS] log_statement and Parse/Bind

2004-05-24 Thread Oliver Jowett
I notice that when using the extended query protocol, statement logging appears to happen only when a Parse message is received. This is less than ideal: - statements can be logged that are not actually executed (i.e. a Parse/Bind with no corresponding Execute). - if statements are re-executed