Re: [HACKERS] logging as inserts

2005-03-03 Thread Josh Berkus
Andrew, > Incidentally, the fly in this particular pot of ointment is that we > potentially log a lot more than just statements. Oh, yeah, but just about anything can be put in the "statement" field; errors, disconnects, etc. Hmmm ... though we don't currently apply "log line prefix" to tho

Re: [HACKERS] logging as inserts

2005-03-03 Thread Andrew Dunstan
Josh Berkus wrote: Tom, But log_line_prefix works fine for all destinations, which is exactly why this new facility isn't a destination. You're just confusing matters by wanting to treat it as one. Hmmm ... hey, if we just allowed extra text in log_line_prefix, and allowed %$ to enclose

Re: [HACKERS] logging as inserts

2005-03-03 Thread Josh Berkus
Tom, > But log_line_prefix works fine for all destinations, which is exactly > why this new facility isn't a destination. You're just confusing > matters by wanting to treat it as one. Hmmm ... hey, if we just allowed extra text in log_line_prefix, and allowed %$ to enclose the statement with l

Re: [HACKERS] logging as inserts

2005-03-03 Thread Tom Lane
Josh Berkus writes: >> I wonder whether this could be defined in a way that lets it replace >> log_line_prefix ... otherwise we have to think about the interaction of >> the two facilities. > Well, that's why I like the idea of using log_destination. It makes it > clear > that log_line_prefix

Re: [HACKERS] logging as inserts

2005-03-03 Thread Josh Berkus
Tom, > That seems a bit bizarre to me. The facility isn't a new log > destination; what it is is a different way of formatting what's > sent to the log. It's not, but it functions like one. And ultimately, the destination *is* someplace different; likely the DBA will be piping the log output t

Re: [HACKERS] logging as inserts

2005-03-03 Thread Tom Lane
Josh Berkus writes: >> What would we like the postgresql.conf option to be? I was thinking >> log_statements_as_inserts = (t/f) > Nope. > log_destination = 'inserts' #not a new GUC! That seems a bit bizarre to me. The facility isn't a new log destination; what it is is a different way of

Re: [HACKERS] logging as inserts

2005-03-03 Thread Josh Berkus
Josh, > >>I am looking at having one of our guys write up the code to allow > >>logging as insert statements. I have a couple of questions. > >> > >>What would we like the postgresql.conf option to be? I was thinking > >>log_statements_as_inserts = (t/f) Nope. log_destination = 'inserts' #n

Re: [HACKERS] logging as inserts

2005-03-02 Thread Andreas Pflug
Gavin Sherry wrote: On Tue, 1 Mar 2005, Joshua D. Drake wrote: Hello, I am looking at having one of our guys write up the code to allow logging as insert statements. I have a couple of questions. What would we like the postgresql.conf option to be? I was thinking log_statements_as_inserts = (t/f)

Re: [HACKERS] logging as inserts

2005-03-02 Thread Christopher Kings-Lynne
Seems to me that a better approach is a script which, given the log file format, is able to parse and allow the user to format the insert themselves. Seems like a cool functionality that could be added to PQA... Chris ---(end of broadcast)--- TIP 3: i

Re: [HACKERS] logging as inserts

2005-03-01 Thread Robert Treat
On Tuesday 01 March 2005 18:16, Gavin Sherry wrote: > On Tue, 1 Mar 2005, Joshua D. Drake wrote: > > Hello, > > > > I am looking at having one of our guys write up the code to allow > > logging as insert statements. I have a couple of questions. > > > > What would we like the postgresql.conf option

Re: [HACKERS] logging as inserts

2005-03-01 Thread Gavin Sherry
On Tue, 1 Mar 2005, Joshua D. Drake wrote: > Hello, > > I am looking at having one of our guys write up the code to allow > logging as insert statements. I have a couple of questions. > > What would we like the postgresql.conf option to be? I was thinking > log_statements_as_inserts = (t/f) > > Ho

[HACKERS] logging as inserts

2005-03-01 Thread Joshua D. Drake
Hello, I am looking at having one of our guys write up the code to allow logging as insert statements. I have a couple of questions. What would we like the postgresql.conf option to be? I was thinking log_statements_as_inserts = (t/f) However I thought that was getting a little silly. Also do we