Re: [HACKERS] logical changeset generation v5

2013-09-05 Thread Andres Freund
Hi, On 2013-09-03 11:40:57 -0400, Robert Haas wrote: > On Fri, Aug 30, 2013 at 11:19 AM, Andres Freund > wrote: > > 0005 wal_decoding: Log xl_running_xact's at a higher frequency than > > checkpoints are done > > * benefits hot standby startup I tried to update the patch to address the comment

Re: [HACKERS] logical changeset generation v5

2013-09-04 Thread Robert Haas
On Tue, Sep 3, 2013 at 7:10 PM, Andres Freund wrote: >> I don't think it particularly needs to be configurable, but I wonder >> if we can't be a bit smarter about when we do it. For example, >> suppose we logged it every 15 s but only until we log a non-overflowed >> snapshot. > > There's actuall

Re: [HACKERS] logical changeset generation v5

2013-09-04 Thread Andres Freund
On 2013-09-04 10:02:05 -0400, Robert Haas wrote: > On Tue, Sep 3, 2013 at 7:10 PM, Andres Freund wrote: > >> I don't think it particularly needs to be configurable, but I wonder > >> if we can't be a bit smarter about when we do it. For example, > >> suppose we logged it every 15 s but only until

Re: [HACKERS] logical changeset generation v5

2013-09-03 Thread Andres Freund
On 2013-09-03 15:56:15 -0400, Robert Haas wrote: > On Tue, Sep 3, 2013 at 12:57 PM, Andres Freund wrote: > >> And why is every 15 seconds good enough? > > > > Waiting 15s to become consistent instead of checkpoint_timeout seems to > > be ok to me and to be a good tradeoff between overhead and wait

Re: [HACKERS] logical changeset generation v5

2013-09-03 Thread Robert Haas
On Tue, Sep 3, 2013 at 12:57 PM, Andres Freund wrote: >> To my way of thinking, it seems as though we ought to always begin >> replay at a checkpoint, so the standby ought always to see one of >> these records immediately. Obviously that's not good enough, but why >> not? > > We always see one af

Re: [HACKERS] logical changeset generation v5

2013-09-03 Thread Andres Freund
On 2013-09-03 12:22:22 -0400, Robert Haas wrote: > On Tue, Sep 3, 2013 at 12:05 PM, Andres Freund wrote: > >> 1. I think more comments are needed here to explain why we need this. > >> I don't know if the comments should go into the functions modified by > >> this patch or in some other location,

Re: [HACKERS] logical changeset generation v5

2013-09-03 Thread Robert Haas
On Tue, Sep 3, 2013 at 12:05 PM, Andres Freund wrote: >> 1. I think more comments are needed here to explain why we need this. >> I don't know if the comments should go into the functions modified by >> this patch or in some other location, but I don't find what's here now >> adequate for understa

Re: [HACKERS] logical changeset generation v5

2013-09-03 Thread Andres Freund
On 2013-09-03 11:40:57 -0400, Robert Haas wrote: > On Fri, Aug 30, 2013 at 11:19 AM, Andres Freund > wrote: > > 0005 wal_decoding: Log xl_running_xact's at a higher frequency than > > checkpoints are done > > * benefits hot standby startup > > Review: > > 1. I think more comments are needed he

Re: [HACKERS] logical changeset generation v5

2013-09-03 Thread Robert Haas
On Fri, Aug 30, 2013 at 11:19 AM, Andres Freund wrote: > 0005 wal_decoding: Log xl_running_xact's at a higher frequency than > checkpoints are done > * benefits hot standby startup Review: 1. I think more comments are needed here to explain why we need this. I don't know if the comments should

Re: [HACKERS] logical changeset generation v5

2013-08-30 Thread Andres Freund
Hi, I've attached a couple of the preliminary patches to $subject which I've recently cleaned up in the hope that we can continue improving on those in a piecemal fashion. I am preparing submission of a newer version of the major patch but unfortunately progress on that is slower than I'd like...

[HACKERS] logical changeset generation v5

2013-06-14 Thread Andres Freund
Hi! I am rather pleased to announce the next version of the changeset extraction patchset. Thanks to help from a large number of people I think we are slowly getting to the point where it is getting committable. Since the last submitted version (20121115002746.ga7...@awork2.anarazel.de) a large n