Re: [HACKERS] logical replication and SIGHUP

2017-04-10 Thread Peter Eisentraut
On 4/9/17 23:20, Michael Paquier wrote: > After more review, I think that got_SIGTERM should be of type volatile > sig_atomic_t in launcher.c or that's not signal-safe. I think as well > that for correctness errno should be saved as SetLatch() is called and > restored afterwards. Please find attach

Re: [HACKERS] logical replication and SIGHUP

2017-04-10 Thread Tom Lane
Petr Jelinek writes: > On 10/04/17 14:40, Tom Lane wrote: >> Umm ... you're doing what? > We are doing: > + SetConfigOption("synchronous_commit", > + MySubscription->synccommit ? > "local" : "off", > + PGC_BACKEND,

Re: [HACKERS] logical replication and SIGHUP

2017-04-10 Thread Petr Jelinek
On 10/04/17 14:40, Tom Lane wrote: > Petr Jelinek writes: >> Looks good to me. Just as a note, we'll have to handle this newly >> supported config rereads in the async commit patch where we override >> synchronous_commit GUC, but the config reread will change it back. > > Umm ... you're doing wha

Re: [HACKERS] logical replication and SIGHUP

2017-04-10 Thread Tom Lane
Petr Jelinek writes: > Looks good to me. Just as a note, we'll have to handle this newly > supported config rereads in the async commit patch where we override > synchronous_commit GUC, but the config reread will change it back. Umm ... you're doing what? There are mechanisms for making local ch

Re: [HACKERS] logical replication and SIGHUP

2017-04-10 Thread Petr Jelinek
On 10/04/17 05:20, Michael Paquier wrote: > On Mon, Apr 10, 2017 at 11:41 AM, Noah Misch wrote: >> On Thu, Apr 06, 2017 at 02:21:29AM +0900, Fujii Masao wrote: >>> Both launcher and worker don't handle SIGHUP signal and cannot >>> reload the configuration. I think that this is a bug. Will add this

Re: [HACKERS] logical replication and SIGHUP

2017-04-09 Thread Michael Paquier
On Mon, Apr 10, 2017 at 11:41 AM, Noah Misch wrote: > On Thu, Apr 06, 2017 at 02:21:29AM +0900, Fujii Masao wrote: >> Both launcher and worker don't handle SIGHUP signal and cannot >> reload the configuration. I think that this is a bug. Will add this as >> an open item barring objection. > > [Act

Re: [HACKERS] logical replication and SIGHUP

2017-04-09 Thread Noah Misch
On Thu, Apr 06, 2017 at 02:21:29AM +0900, Fujii Masao wrote: > Both launcher and worker don't handle SIGHUP signal and cannot > reload the configuration. I think that this is a bug. Will add this as > an open item barring objection. [Action required within three days. This is a generic notificati

Re: [HACKERS] logical replication and SIGHUP

2017-04-05 Thread Peter Geoghegan
On Wed, Apr 5, 2017 at 10:21 AM, Fujii Masao wrote: > Both launcher and worker don't handle SIGHUP signal and cannot > reload the configuration. I think that this is a bug. +1 -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your su

[HACKERS] logical replication and SIGHUP

2017-04-05 Thread Fujii Masao
Hi, Both launcher and worker don't handle SIGHUP signal and cannot reload the configuration. I think that this is a bug. Will add this as an open item barring objection. Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subs