Peter Eisentraut writes:
> Since some people didn't like removing the hint about "installcheck",
> I'd suggest just removing the "exit 1", which should then be pretty
> consistent overall.
Works for me.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hac
On mån, 2011-04-25 at 13:12 -0400, Tom Lane wrote:
> Peter Eisentraut writes:
> > On mån, 2011-04-25 at 11:22 -0400, Tom Lane wrote:
> >> The proposed patch is to fix it, not remove it. Surely that's more
> >> useful than a no-op target.
>
> > The proposed patch will support make check for contr
Peter Eisentraut writes:
> On mån, 2011-04-25 at 11:22 -0400, Tom Lane wrote:
>> The proposed patch is to fix it, not remove it. Surely that's more
>> useful than a no-op target.
> The proposed patch will support make check for contrib modules, but not
> for external users of pgxs.
So what wil
On mån, 2011-04-25 at 11:22 -0400, Tom Lane wrote:
> Robert Haas writes:
> > On Mon, Apr 25, 2011 at 10:21 AM, Tom Lane wrote:
> >> Robert Haas writes:
> >>> On Sun, Apr 24, 2011 at 7:18 PM, Peter Eisentraut wrote:
> I noticed again that make check in contrib doesn't work, so here is a
> >
On Mon, Apr 25, 2011 at 11:22 AM, Tom Lane wrote:
> Robert Haas writes:
>> On Mon, Apr 25, 2011 at 10:21 AM, Tom Lane wrote:
>>> Robert Haas writes:
On Sun, Apr 24, 2011 at 7:18 PM, Peter Eisentraut wrote:
> I noticed again that make check in contrib doesn't work, so here is a
> p
Robert Haas writes:
> On Mon, Apr 25, 2011 at 10:21 AM, Tom Lane wrote:
>> Robert Haas writes:
>>> On Sun, Apr 24, 2011 at 7:18 PM, Peter Eisentraut wrote:
I noticed again that make check in contrib doesn't work, so here is a
patch to fix it.
>>> I think it might be more useful to ha
On Mon, Apr 25, 2011 at 10:21 AM, Tom Lane wrote:
> Robert Haas writes:
>> On Sun, Apr 24, 2011 at 7:18 PM, Peter Eisentraut wrote:
>>> I noticed again that make check in contrib doesn't work, so here is a
>>> patch to fix it.
>
>> I think it might be more useful to have a check target that actu
Robert Haas writes:
> On Sun, Apr 24, 2011 at 7:18 PM, Peter Eisentraut wrote:
>> I noticed again that make check in contrib doesn't work, so here is a
>> patch to fix it.
> I think it might be more useful to have a check target that actually
> succeeds, even if it does nothing useful.
That arg
On 04/25/2011 08:53 AM, Robert Haas wrote:
The argument that no check
target at all is more useful than a check target that fails with a
reasonably informative error message seems week to me.
+1 (weak too)
cheers
andrew
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
On Sun, Apr 24, 2011 at 7:18 PM, Peter Eisentraut wrote:
> I noticed again that make check in contrib doesn't work, so here is a
> patch to fix it. Perhaps someone wants to fill in the Windows support
> for it. Naturally, this works only for contrib itself, not for external
> packages that use p
I noticed again that make check in contrib doesn't work, so here is a
patch to fix it. Perhaps someone wants to fill in the Windows support
for it. Naturally, this works only for contrib itself, not for external
packages that use pgxs.
A secondary issue that actually led to this: I was preparin
11 matches
Mail list logo
