Re: [HACKERS] make dist does not work in VPATH

2008-08-20 Thread Alvaro Herrera
Peter Eisentraut wrote: > Fix option 1 would be to copy the build tree as well, if it is different from > the source tree. Since the build tree contains a bunch of symlinks back to > the source tree, this would probably need some careful file handling to not > overwrite the real files with sym

Re: [HACKERS] make dist does not work in VPATH

2008-08-20 Thread Peter Eisentraut
Alvaro Herrera wrote: > It seems we're neglecting to copy GNUmakefile into the temporary > distdir: > make -C postgresql-8.3.3 distprep > make[1]: entrant dans le répertoire « > /home/alvherre/Code/CVS/pgsql/build/83_rel/postgresql-8.3.3 » make[1]: *** > Pas de règle pour fabriquer la cible « dist

Re: [HACKERS] make dist does not work in VPATH

2008-08-20 Thread Alvaro Herrera
Tom Lane wrote: > Is it sensible for make dist to work in a VPATH? Seems like the entire > point of that operation is to modify the source tree. Actually the point AFAICS is to generate a tarball. Why wouldn't it work in a VPATH build? -- Alvaro Herrerahttp://ww

Re: [HACKERS] make dist does not work in VPATH

2008-08-20 Thread Tom Lane
Is it sensible for make dist to work in a VPATH? Seems like the entire point of that operation is to modify the source tree. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresq

[HACKERS] make dist does not work in VPATH

2008-08-20 Thread Alvaro Herrera
Hi, It seems we're neglecting to copy GNUmakefile into the temporary distdir: $ pwd /pgsql/build/83_rel $ make dist rm -rf postgresql-8.3.3* =install= for x in `cd /pgsql/source/83_rel && find . -name CVS -prune -o -print`; do \ file=`expr X$x : 'X\./\(.*\)'`; \ if test -d "/p