Re: [HACKERS] missing "else" in postmaster.c?

2010-06-22 Thread Alvaro Herrera
Excerpts from Robert Haas's message of lun jun 21 22:18:46 -0400 2010: > In pmdie(), we have the following code, which doesn't seem to make > much sense. If the state is PM_RECOVERY at the top of this section it > will get changed to PM_WAIT_BACKENDS and then to PM_WAIT_BACKENDS > again. Either t

[HACKERS] missing "else" in postmaster.c?

2010-06-21 Thread Robert Haas
In pmdie(), we have the following code, which doesn't seem to make much sense. If the state is PM_RECOVERY at the top of this section it will get changed to PM_WAIT_BACKENDS and then to PM_WAIT_BACKENDS again. Either the two "if" statements should be merged (and both bits should be handled with t