Hannes Eder wrote:
(a) use the current dir "." instead of "../.." for the *.sample files,
since there are the chdir's to ../../.. resp. to ../../../.. in line
28 resp. 29. Using ../.. would traverse a too large part of the
directory structure.
Actually, it should be restricted more, to sr
Magnus Hagander schrieb:
Tom Lane wrote:
Magnus Hagander <[EMAIL PROTECTED]> writes:
Andrew Dunstan wrote:
I have committed a fix that is somewhat similar to this. The Install.pm
module needs some love, but that will have to wait till the next cycle.
Thanks, Andrew!
Tom Lane wrote:
Magnus Hagander <[EMAIL PROTECTED]> writes:
Andrew Dunstan wrote:
I have committed a fix that is somewhat similar to this. The Install.pm
module needs some love, but that will have to wait till the next cycle.
Thanks, Andrew!
Guys, would you comment
Tom Lane wrote:
> Magnus Hagander <[EMAIL PROTECTED]> writes:
>> Andrew Dunstan wrote:
>>> I have committed a fix that is somewhat similar to this. The Install.pm
>>> module needs some love, but that will have to wait till the next cycle.
>
>> Thanks, Andrew!
>
> Guys, would you comment on whethe
Magnus Hagander <[EMAIL PROTECTED]> writes:
> Andrew Dunstan wrote:
>> I have committed a fix that is somewhat similar to this. The Install.pm
>> module needs some love, but that will have to wait till the next cycle.
> Thanks, Andrew!
Guys, would you comment on whether this patch closes all the
Andrew Dunstan wrote:
> Hannes Eder wrote:
>> Magnus Hagander wrote:
>> >Hannes Eder wrote:
>> >> Is it worth doing this the "Perl-way" and using File::Find? If so,
>> I can
>> >> work an a patch for that.
>> >>
>> > It's certainly cleaner that way, but I don't find it a major issue.
>> But I'd
>>
Hannes Eder wrote:
Magnus Hagander wrote:
>Hannes Eder wrote:
>> Is it worth doing this the "Perl-way" and using File::Find? If so,
I can
>> work an a patch for that.
>>
> It's certainly cleaner that way, but I don't find it a major issue.
But I'd
> rather see that fix than the other one.
Magnus Hagander schrieb:
I used to have a different patch from Andrew that did part of this, and
more, and conflicted rather badly with it. However, I never got around
to applying that one, and I can't seem to find it anymore.
Andrew -do you recall if you had all this in yours, and is it still
s
I am fighting some fires in my day job.
My pesonal TODO list for pg up to beta is:
. fix chunking muddle (see recent emails)
. complete CSV logs patch
. harden MSVC builds
I'll get to this when I can. I can dig up the patch I did if you want
it again.
cheers
andrew
Magnus Hagander wrote
I used to have a different patch from Andrew that did part of this, and
more, and conflicted rather badly with it. However, I never got around
to applying that one, and I can't seem to find it anymore.
Andrew -do you recall if you had all this in yours, and is it still
something you want in, or sh
Magnus, what is your reaction to this patch?
---
Hannes Eder wrote:
> Magnus Hagander wrote:
> >Hannes Eder wrote:
> >> Is it worth doing this the "Perl-way" and using File::Find? If so, I
> can
> >> work an a patch for
Magnus Hagander wrote:
>Hannes Eder wrote:
>> Is it worth doing this the "Perl-way" and using File::Find? If so, I
can
>> work an a patch for that.
>>
> It's certainly cleaner that way, but I don't find it a major issue.
But I'd
> rather see that fix than the other one.
Here we go. See attach
On Wed, May 30, 2007 at 01:56:24PM +0200, Hannes Eder wrote:
> Magnus Hagander schrieb:
> >Are you actually *running* the script from inside cygwin? How else does it
> >pick up the wrong command processor?
> >
> I run the script within cmd.exe, but cygwin´s /usr/bin directory is in
> my PATH, th
Magnus Hagander schrieb:
Are you actually *running* the script from inside cygwin? How else does it
pick up the wrong command processor?
I run the script within cmd.exe, but cygwin´s /usr/bin directory is in
my PATH, therefor cygwin dir executable is in the PATH (/usr/bin/dir).
Instead of ru
On Wed, May 30, 2007 at 12:09:05PM +0200, Hannes Eder wrote:
> Andrew Dunstan schrieb:
> >Hannes Eder wrote:
> >>-open($D, "dir /b $subdirs $spec |") || croak "Could not list
> >>$spec\n";
> >>+open($D, "cmd /c dir /b $subdirs $spec |") || croak "Could not
> >>list $spec\n";
> >>
> >
> >
Andrew Dunstan schrieb:
Hannes Eder wrote:
-open($D, "dir /b $subdirs $spec |") || croak "Could not list
$spec\n";
+open($D, "cmd /c dir /b $subdirs $spec |") || croak "Could not
list $spec\n";
What the heck are we doing here anyway? We should be doing this a la
Perl - calling out
Hannes Eder wrote:
-open($D, "dir /b $subdirs $spec |") || croak "Could not list $spec\n";
+open($D, "cmd /c dir /b $subdirs $spec |") || croak "Could not list
$spec\n";
What the heck are we doing here anyway? We should be doing this a la
Perl - calling out to "dir /b" is surely
With a small modification to src/tools/msvc/Install.pm (see attached
patch) it's possible for me to build with msvc and install postgres on a
Windows xp box and leave cygwin in the PATH. Since I use cygwin
frequently it's usfull for me to have it in the PATH.
This might not work on Win9x platf
18 matches
Mail list logo
