Re: [HACKERS] need more ALTER TABLE guards for typed tables

2010-07-22 Thread Peter Eisentraut
On ons, 2010-07-21 at 15:48 -0400, Alvaro Herrera wrote: Excerpts from Peter Eisentraut's message of mié jul 21 15:18:58 -0400 2010: After some investigation I figured that I need to add two more checks into the ALTER TABLE code to prevent certain types of direct changes to typed tables

[HACKERS] need more ALTER TABLE guards for typed tables

2010-07-21 Thread Peter Eisentraut
After some investigation I figured that I need to add two more checks into the ALTER TABLE code to prevent certain types of direct changes to typed tables (see attached patch). But it's not clear to me whether such checks should go into the Prep or the Exec phases. Prep seems more plausible to

Re: [HACKERS] need more ALTER TABLE guards for typed tables

2010-07-21 Thread Alvaro Herrera
Excerpts from Peter Eisentraut's message of mié jul 21 15:18:58 -0400 2010: After some investigation I figured that I need to add two more checks into the ALTER TABLE code to prevent certain types of direct changes to typed tables (see attached patch). But it's not clear to me whether such