Re: [HACKERS] new initdb.c available

2003-10-08 Thread Zeugswetter Andreas SB SD
. using wb for writing out on Windows is so that we don't get Windows' gratuitous addition of carriage returns. I will document that. Please use the #define PG_BINARY_W from c.h which is defined with the correct letters for all platforms (wb on Windows). That is how Peter's comment was

Re: [HACKERS] new initdb.c available

2003-10-08 Thread Andrew Dunstan
Zeugswetter Andreas SB SD wrote: . using wb for writing out on Windows is so that we don't get Windows' gratuitous addition of carriage returns. I will document that. Please use the #define PG_BINARY_W from c.h which is defined with the correct letters for all platforms (wb on Windows).

[HACKERS] new initdb.c available

2003-10-06 Thread Andrew Dunstan
- Original Message - From: Andrew Dunstan [EMAIL PROTECTED] Yes, but when I asked that question at least one voice piped up (Debian package maintainer, I think) to say that these were still needed as standalone programs. However, I have already replaced the calls I previously had to

Re: [HACKERS] new initdb.c available

2003-10-06 Thread Peter Eisentraut
Andrew Dunstan writes: New version has passed basic Windows tests, and is available (with new Makefile too) at http://www.dunslane.net/~andrew/Initdb_In_C.html constructive comments (very) welcome. That looks very nice. Just some nitpicking comments. (Most of these comments should be

Re: [HACKERS] new initdb.c available

2003-10-06 Thread Andrew Dunstan
Thanks. I will attend to most of this. A couple of points: . using wb for writing out on Windows is so that we don't get Windows' gratuitous addition of carriage returns. I will document that. . I can't use do { stuff; } while(0) for a macro that does declarations - the declarations would be

Re: [HACKERS] new initdb.c available

2003-10-06 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: Doesn't pg_indent do the spacing for us when code is merged? For the most part it will. You can ask Bruce to run the code through it for you if you don't have BSD indent handy. regards, tom lane ---(end

Re: [HACKERS] new initdb.c available

2003-10-06 Thread Bruce Momjian
Andrew Dunstan wrote: Thanks. I will attend to most of this. A couple of points: . using wb for writing out on Windows is so that we don't get Windows' gratuitous addition of carriage returns. I will document that. . I can't use do { stuff; } while(0) for a macro that does declarations