Re: [HACKERS] odd convert_from bug

2008-01-09 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > BTW, if calling pfree() at all here is actually a bug, then we should > probably fix it in the back branches. It looks more to me like the > problem was that pg_convert_from was calling pfree() with the wrong > argument - src_encoding_name instead of

Re: [HACKERS] odd convert_from bug

2008-01-09 Thread Andrew Dunstan
Andrew Dunstan wrote: Tom Lane wrote: Andrew Dunstan <[EMAIL PROTECTED]> writes: The case below has just been reported to me. It sure looks odd. I'm looking into it but any ideas would be welcome. The problem only occurs if we are updating more than one row. Pfree'ing something yo

Re: [HACKERS] odd convert_from bug

2008-01-09 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan <[EMAIL PROTECTED]> writes: The case below has just been reported to me. It sure looks odd. I'm looking into it but any ideas would be welcome. The problem only occurs if we are updating more than one row. Pfree'ing something you didn't palloc is bad n

Re: [HACKERS] odd convert_from bug

2008-01-09 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > The case below has just been reported to me. It sure looks odd. I'm > looking into it but any ideas would be welcome. The problem only occurs > if we are updating more than one row. Pfree'ing something you didn't palloc is bad news...

[HACKERS] odd convert_from bug

2008-01-09 Thread Andrew Dunstan
The case below has just been reported to me. It sure looks odd. I'm looking into it but any ideas would be welcome. The problem only occurs if we are updating more than one row. cheers andrew andrew=# select getdatabaseencoding(); getdatabaseencoding - UTF8 (1 row) and