Re: [HACKERS] patch: ALTER TABLE IF EXISTS

2012-01-27 Thread Heikki Linnakangas
On 27.01.2012 11:57, Dean Rasheed wrote: I just noticed this copy-and-paste error in the ALTER FOREIGN TABLE docs: IF EXISTS: Do not throw an error if the sequence does not exist. A notice is issued in this case. That should be "foreign table" not "sequence". Thanks, fixed. --

Re: [HACKERS] patch: ALTER TABLE IF EXISTS

2012-01-27 Thread Dean Rasheed
On 23 January 2012 20:14, Pavel Stehule wrote: > Hello > > 2012/1/23 Robert Haas : >> On Tue, Jan 3, 2012 at 2:49 PM, Pavel Stehule >> wrote: >>> jup, we can continue in enhancing step by step. >>> >>> I change a patch and now ALTER TABLE, ALTER INDEX, ALTER SEQUENCE and >>> ALTER VIEW has IF EX

Re: [HACKERS] patch: ALTER TABLE IF EXISTS

2012-01-23 Thread Robert Haas
On Tue, Jan 3, 2012 at 2:49 PM, Pavel Stehule wrote: > jup, we can continue in enhancing step by step. > > I change a patch and now ALTER TABLE, ALTER INDEX, ALTER SEQUENCE and > ALTER VIEW has IF EXISTS clause ALTER FOREIGN TABLE should be parallel as well, I think. -- Robert Haas EnterpriseDB

Re: [HACKERS] patch: ALTER TABLE IF EXISTS

2012-01-23 Thread Simon Riggs
On Tue, Jan 3, 2012 at 7:49 PM, Pavel Stehule wrote: > I change a patch and now ALTER TABLE, ALTER INDEX, ALTER SEQUENCE and > ALTER VIEW has IF EXISTS clause Patch no longer applies. Pls update. --  Simon Riggs   http://www.2ndQuadrant.com/  PostgreSQL Development, 24x7 Suppor

Re: [HACKERS] patch: ALTER TABLE IF EXISTS

2012-01-03 Thread Pavel Stehule
Hello 2012/1/3 Robert Haas : > On Tue, Jan 3, 2012 at 10:38 AM, Pavel Stehule > wrote: >> Hello >> >> 2012/1/3 Robert Haas : >>> On Mon, Jan 2, 2012 at 12:01 PM, Pavel Stehule >>> wrote: here is updated patch >>> >>> I think the comments in parse_utilcmd.c probably need a bit of adjustmen

Re: [HACKERS] patch: ALTER TABLE IF EXISTS

2012-01-03 Thread Robert Haas
On Tue, Jan 3, 2012 at 10:38 AM, Pavel Stehule wrote: > Hello > > 2012/1/3 Robert Haas : >> On Mon, Jan 2, 2012 at 12:01 PM, Pavel Stehule >> wrote: >>> here is updated patch >> >> I think the comments in parse_utilcmd.c probably need a bit of adjustment. > > I don't see it - there is only one c

Re: [HACKERS] patch: ALTER TABLE IF EXISTS

2012-01-03 Thread Pavel Stehule
Hello 2012/1/3 Robert Haas : > On Mon, Jan 2, 2012 at 12:01 PM, Pavel Stehule > wrote: >> here is updated patch > > I think the comments in parse_utilcmd.c probably need a bit of adjustment. I don't see it - there is only one comment and it is adjusted with "if" statement. please, show it Reg

Re: [HACKERS] patch: ALTER TABLE IF EXISTS

2012-01-03 Thread Robert Haas
On Mon, Jan 2, 2012 at 12:01 PM, Pavel Stehule wrote: > here is updated patch I think the comments in parse_utilcmd.c probably need a bit of adjustment. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hac

Re: [HACKERS] patch: ALTER TABLE IF EXISTS

2012-01-02 Thread Pavel Stehule
Hello here is updated patch Regards Pavel 2012/1/2 Simon Riggs : > On Mon, Jan 2, 2012 at 1:11 PM, Pavel Stehule wrote: > >> this is relative simple patch that add possibility to skip noexisting >> tables. It is necessary for silent cleaning when dump is loaded. > > Agreed, nice simple and un

Re: [HACKERS] patch: ALTER TABLE IF EXISTS

2012-01-02 Thread Pavel Stehule
Hello 2012/1/2 Tomas Vondra : > On 2 Leden 2012, 14:11, Pavel Stehule wrote: >> Hello >> >> this is relative simple patch that add possibility to skip noexisting >> tables. It is necessary for silent cleaning when dump is loaded. > > Just a curious question - what use case is solved by this? Under

Re: [HACKERS] patch: ALTER TABLE IF EXISTS

2012-01-02 Thread Tomas Vondra
On 2 Leden 2012, 14:11, Pavel Stehule wrote: > Hello > > this is relative simple patch that add possibility to skip noexisting > tables. It is necessary for silent cleaning when dump is loaded. Just a curious question - what use case is solved by this? Under what circumstances you get an ALTER TAB

Re: [HACKERS] patch: ALTER TABLE IF EXISTS

2012-01-02 Thread Simon Riggs
On Mon, Jan 2, 2012 at 1:11 PM, Pavel Stehule wrote: > this is relative simple patch that add possibility to skip noexisting > tables. It is necessary for silent cleaning when dump is loaded. Agreed, nice simple and uncontentious patch. All good apart from two minor things: * doc page needs to

[HACKERS] patch: ALTER TABLE IF EXISTS

2012-01-02 Thread Pavel Stehule
Hello this is relative simple patch that add possibility to skip noexisting tables. It is necessary for silent cleaning when dump is loaded. Regards Pavel Stehule *** ./doc/src/sgml/ref/alter_table.sgml.orig 2011-12-01 22:47:20.0 +0100 --- ./doc/src/sgml/ref/alter_table.sgml 2012-01-02 1