Re: [HACKERS] pg.conf re-reading in signal handler or at next return

2006-03-06 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > Code comment patch applied. Thanks. > > The comment was in fact correct as it stood, though in different ways > for the postmaster and backend --- in the postmaster it alludes to the > fact that we only enable signals at one point in the postmaster loo

Re: [HACKERS] pg.conf re-reading in signal handler or at next return to main loop?

2006-03-06 Thread Tom Lane
Bruce Momjian writes: > Code comment patch applied. Thanks. The comment was in fact correct as it stood, though in different ways for the postmaster and backend --- in the postmaster it alludes to the fact that we only enable signals at one point in the postmaster loop.

Re: [HACKERS] pg.conf re-reading in signal handler or at next return

2006-03-06 Thread Bruce Momjian
Code comment patch applied. Thanks. --- Markus Bertheau wrote: > 2006/3/6, Tom Lane <[EMAIL PROTECTED]>: > > > > The comment is referring to the control flow in a backend; you're > > looking at the postmaster's sighup handl

Re: [HACKERS] pg.conf re-reading in signal handler or at next return to main loop?

2006-03-06 Thread Markus Bertheau
2006/3/6, Tom Lane <[EMAIL PROTECTED]>: > > The comment is referring to the control flow in a backend; you're > looking at the postmaster's sighup handler, which is different. Then the following comment patch is appropriate, afaics. Markus Bertheau Index: src/include/utils/guc.h =

Re: [HACKERS] pg.conf re-reading in signal handler or at next return to main loop?

2006-03-05 Thread Tom Lane
"Markus Bertheau" <[EMAIL PROTECTED]> writes: > SIGHUP_handler() calls ProcessConfigFile() which calls > ParseConfigFile() which reads postgresql.conf. > For me that means that postgresql.conf in read in the signal handler, > which contradicts the claim in the README. Where's my error? The commen

[HACKERS] pg.conf re-reading in signal handler or at next return to main loop?

2006-03-05 Thread Markus Bertheau
Hi, src/backend/utils/misc/README says " If SIGHUP is received, the GUC code rereads the postgresql.conf configuration file (this does not happen in the signal handler, but at next return to main loop; note that it can be executed while within a transaction). " SIGHUP_handler() calls ProcessConf