Re: [HACKERS] pg_archivecleanup should remove WAL files also in pg_xlog?

2010-12-13 Thread Fujii Masao
On Mon, Dec 13, 2010 at 6:02 PM, Fujii Masao wrote: > Yep, that's recommended in the document, but I don't want to use that. > Because that might make new master fail to archive WAL file because of > existence of half-baked file in the archive, after failover. This can happen > if the master crash

Re: [HACKERS] pg_archivecleanup should remove WAL files also in pg_xlog?

2010-12-13 Thread Fujii Masao
On Mon, Dec 13, 2010 at 5:01 PM, Heikki Linnakangas wrote: > If the only consequence is that you get some extra WAL files in the archive, > until pg_archivecleanup runs again, I think we can just live with it. We might get some extra WAL files also in pg_xlog. Because the WAL files which don't ha

Re: [HACKERS] pg_archivecleanup should remove WAL files also in pg_xlog?

2010-12-13 Thread Heikki Linnakangas
On 13.12.2010 09:50, Fujii Masao wrote: On Mon, Dec 13, 2010 at 4:28 PM, Heikki Linnakangas wrote: On 13.12.2010 08:44, Fujii Masao wrote: pg_archivecleanup removes unnecessary WAL files from the archive, but not from pg_xlog directory. So, after failover, those WAL files might exist in pg_x

Re: [HACKERS] pg_archivecleanup should remove WAL files also in pg_xlog?

2010-12-12 Thread Fujii Masao
On Mon, Dec 13, 2010 at 4:28 PM, Heikki Linnakangas wrote: > On 13.12.2010 08:44, Fujii Masao wrote: >> >> pg_archivecleanup removes unnecessary WAL files from the archive, but not >> from pg_xlog directory. So, after failover, those WAL files might >> exist in pg_xlog and be archived again later.

Re: [HACKERS] pg_archivecleanup should remove WAL files also in pg_xlog?

2010-12-12 Thread Heikki Linnakangas
On 13.12.2010 08:44, Fujii Masao wrote: pg_archivecleanup removes unnecessary WAL files from the archive, but not from pg_xlog directory. So, after failover, those WAL files might exist in pg_xlog and be archived again later. A file that has already been archived successfully should not be arc

Re: [HACKERS] pg_archivecleanup should remove WAL files also in pg_xlog?

2010-12-12 Thread Fujii Masao
On Mon, Dec 13, 2010 at 3:44 PM, Fujii Masao wrote: > pg_archivecleanup removes unnecessary WAL files from the archive, but not > from pg_xlog directory. So, after failover, those WAL files might > exist in pg_xlog > and be archived again later. Re-archiving of unnecessary WAL files seems odd > to

[HACKERS] pg_archivecleanup should remove WAL files also in pg_xlog?

2010-12-12 Thread Fujii Masao
Hi, pg_archivecleanup removes unnecessary WAL files from the archive, but not from pg_xlog directory. So, after failover, those WAL files might exist in pg_xlog and be archived again later. Re-archiving of unnecessary WAL files seems odd to me. To avoid this problem, how about changing pg_archivec