2009/8/8 Bruce Momjian :
> Just to verify, this patch was about comments on composite columns, not
> about dumping comments on index columns (as the subject states), right?
> We do have a TODO for index column comments:
Correct.
If you scroll up a couple of messages [1] you'll see that I added th
Tom Lane wrote:
> Brendan Jurd writes:
> > I've also done an initial review of the patch. Everything looks sane
> > and the patch works as advertised. I made a couple of minor tweaks
> > for code-style and comment consistency, and my version 3 is attached.
>
> > I'm marking this patch Ready for
Brendan Jurd writes:
> I've also done an initial review of the patch. Everything looks sane
> and the patch works as advertised. I made a couple of minor tweaks
> for code-style and comment consistency, and my version 3 is attached.
> I'm marking this patch Ready for Committer.
Applied with mi
2009/7/14 Jaime Casanova :
> On Thu, Mar 26, 2009 at 2:39 AM, higepon wrote:
>> Here is a patch for pg_dump "Commenting on a composite-type column".
>> This patch is for Todo item named "Add dumping of comments on index
>> columns and composite type columns".
>
> this one looks good to me, the only
Jaime Casanova wrote:
> this one looks good to me, the only adjust i made to the patch is
Thank you for your review!
---
Taro Minowa(Higepon)
http://www.monaos.org/
http://code.google.com/p/mosh-scheme/
On Tue, Jul 14, 2009 at 4:34 PM, Jaime
Casanova wrote:
> On Thu, Mar 26, 2009 at 2:39 A
On Thu, Mar 26, 2009 at 2:39 AM, higepon wrote:
> Hi.
>
> Here is a patch for pg_dump "Commenting on a composite-type column".
> This patch is for Todo item named "Add dumping of comments on index
> columns and composite type columns".
this one looks good to me, the only adjust i made to the patch
Hi.
> Since we are about to go to beta, it may be that no one is up for
> reviewing it right now. But I've added it to the CommitFest page for
> the next CommitFest.
Thank you.
I wait until the next CommitFest.
-
Taro Minowa(Higepon)
http://www.monaos.org/
http://code.google.com/p/mosh-sch
> Would someone please review this?
Since we are about to go to beta, it may be that no one is up for
reviewing it right now. But I've added it to the CommitFest page for
the next CommitFest.
http://wiki.postgresql.org/wiki/CommitFest_2009-First
...Robert
--
Sent via pgsql-hackers mailing lis
Hi.
Here is a patch for pg_dump "Commenting on a composite-type column".
This patch is for Todo item named "Add dumping of comments on index
columns and composite type columns".
As Tom Lane said, this patch is not for dumping "comments on index columns",
but only for "comment on composite-type col
Bruce Momjian writes:
> Wow, I have no idea what that means. I am wondering if we should just
> remove this TODO item. We don't even support comments on indexed
> columns, so why would pg_dump need to dump it?
The system will let you do it, both cases:
regression=# create type foo as (f1 int,
Hi.
> Wow, I have no idea what that means. I am wondering if we should just
> remove this TODO item. We don't even support comments on indexed
> columns, so why would pg_dump need to dump it?
Oh I see.
But we still can comment on indexed columns like following on 8.3.7,
is it unsupported featur
higepon wrote:
> Hi.
> I found a TODO item "Add dumping of comments on index columns and
> composite type columns" for pg_dump
> and want to write a patch for it.
>
> But I'm not sure if I understand the problem correctly.
> Does "Add dumping of comments on index columns" mean that
> pg_dump shoul
Hi.
I found a TODO item "Add dumping of comments on index columns and
composite type columns" for pg_dump
and want to write a patch for it.
But I'm not sure if I understand the problem correctly.
Does "Add dumping of comments on index columns" mean that
pg_dump should dump out COMMENT statements l
Hi.
I found a TODO item "Add dumping of comments on index columns and
composite type columns" for pg_dump
and want to write a patch for it.
But I'm not sure if I understand the problem correctly.
Does "Add dumping of comments on index columns" mean that
pg_dump should dump out COMMENT statements l
14 matches
Mail list logo
