Re: [HACKERS] pg_dump end comment

2004-03-31 Thread scott.marlowe
On Wed, 31 Mar 2004, Philip Warner wrote: > At 12:13 AM 31/03/2004, Bruce Momjian wrote: > >Yes, they have to check for a proper exit from pg_dump, but there is > >still a file sitting around after the dump, with no way to tell if it is > >accurate. > > Why don't we write a hash into the header o

Re: [HACKERS] pg_dump end comment

2004-03-30 Thread Christopher Kings-Lynne
I like an end-of-dump marker for folks who want to check if the dump got truncated somehow. I can see how to do that for text dumps, but what about for tar or custom dumps? Wouldn't it be more effective to test for non zero return status as this handles -Fc cases, etc, which would be non-trivial t

Re: [HACKERS] pg_dump end comment

2004-03-30 Thread Philip Warner
At 12:13 AM 31/03/2004, Bruce Momjian wrote: Yes, they have to check for a proper exit from pg_dump, but there is still a file sitting around after the dump, with no way to tell if it is accurate. Why don't we write a hash into the header or footer. Then use something like: pg_restore --verify

Re: [HACKERS] pg_dump end comment

2004-03-30 Thread Bruce Momjian
Gavin Sherry wrote: > On Tue, 30 Mar 2004, Bruce Momjian wrote: > > > Tom Lane wrote: > > > Christopher Kings-Lynne <[EMAIL PROTECTED]> writes: > > > > This might seem a bit silly, but is there any chance we could add a > > > > comment at the end of pg_dump text output that says '-- End of dump'?

Re: [HACKERS] pg_dump end comment

2004-03-30 Thread Tom Lane
Gavin Sherry <[EMAIL PROTECTED]> writes: > On Tue, 30 Mar 2004, Bruce Momjian wrote: >> I like an end-of-dump marker for folks who want to check if the dump got >> truncated somehow. I can see how to do that for text dumps, but what >> about for tar or custom dumps? > Wouldn't it be more effectiv

Re: [HACKERS] pg_dump end comment

2004-03-30 Thread Gavin Sherry
On Tue, 30 Mar 2004, Bruce Momjian wrote: > Tom Lane wrote: > > Christopher Kings-Lynne <[EMAIL PROTECTED]> writes: > > > This might seem a bit silly, but is there any chance we could add a > > > comment at the end of pg_dump text output that says '-- End of dump'? > > > > Sure --- while you're at

Re: [HACKERS] pg_dump end comment

2004-03-29 Thread Bruce Momjian
Tom Lane wrote: > Christopher Kings-Lynne <[EMAIL PROTECTED]> writes: > > This might seem a bit silly, but is there any chance we could add a > > comment at the end of pg_dump text output that says '-- End of dump'? > > Sure --- while you're at it, put a "beginning of dump" at the start. > > Is

Re: [HACKERS] pg_dump end comment

2004-03-29 Thread Tom Lane
Christopher Kings-Lynne <[EMAIL PROTECTED]> writes: > This might seem a bit silly, but is there any chance we could add a > comment at the end of pg_dump text output that says '-- End of dump'? Sure --- while you're at it, put a "beginning of dump" at the start. Is it worth adding the database n

[HACKERS] pg_dump end comment

2004-03-29 Thread Christopher Kings-Lynne
This might seem a bit silly, but is there any chance we could add a comment at the end of pg_dump text output that says '-- End of dump'? Would make it useful for checking that you actually have a complete dump... Chris ---(end of broadcast)--- TI