I have pushed this, thanks.
--
Álvaro Herrerahttp://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsq
Alvaro Herrera wrote:
> Here's the complete patch in case anyone is wondering.
I found out that with just a little bit of extra header hacking, the
whole thing ends up cleaner -- for instance, with the attached patch,
pg_backup_archiver.h is no longer needed by pg_backup_db.h. I also
tweaked thin
On Sat, Oct 11, 2014 at 10:15 PM, Alvaro Herrera
wrote:
>
> Fabrízio de Royes Mello wrote:
> > On Sat, Oct 11, 2014 at 2:56 PM, Alvaro Herrera <
alvhe...@2ndquadrant.com>
> > wrote:
> >
> > > Here's the complete patch in case anyone is wondering.
> > >
> > >
> > Hi,
> >
> > Your patch doesn't appl
Fabrízio de Royes Mello wrote:
> On Sat, Oct 11, 2014 at 2:56 PM, Alvaro Herrera
> wrote:
>
> > Here's the complete patch in case anyone is wondering.
> >
> >
> Hi,
>
> Your patch doesn't apply to master:
I think your email system mangled it. I can download it from archives
and apply it just
On Sat, Oct 11, 2014 at 2:56 PM, Alvaro Herrera
wrote:
> Here's the complete patch in case anyone is wondering.
>
>
Hi,
Your patch doesn't apply to master:
$ git apply ~/Downloads/pg_dump_refactor_globals.6.diff
/home/fabrizio/Downloads/pg_dump_refactor_globals.6.diff:10: trailing
whitespace.
Here's the complete patch in case anyone is wondering.
--
Álvaro Herrerahttp://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
diff --git a/src/bin/pg_dump/common.c b/src/bin/pg_dump/common.c
index 2f855cf..17e9574 100644
--- a/src/bin/pg_dump/common
Joachim Wieland wrote:
> On Sat, Aug 30, 2014 at 11:12 PM, Peter Eisentraut wrote:
> > - The forward declaration of struct _dumpOptions in pg_backup.h seems
> > kind of useless. You could move some things around so that that's not
> > necessary.
>
> Agreed, fixed.
>
> > - NewDumpOptions() and
Here's a rebased patch for this (I also pgindented it).
One thing I find a bit odd is the fact that we copy
RestoreOptions->superuser into DumpOptions->outputSuperuser (a char *
pointer) without pstrdup or similar. We're already doing the inverse
elsewhere, and the uses of the routine where this
Joachim Wieland wrote:
> On Sat, Aug 30, 2014 at 11:12 PM, Peter Eisentraut wrote:
> > - Why is quote_all_identifiers left behind as a global variable?
>
> As I said, it's really used everywhere. I'm not opposed to passing it
> around (which would be straightforward) but it would really blow up
The general idea of this patch is not disputed, I think.
Some concerns about the details:
- Why is quote_all_identifiers left behind as a global variable?
- Shouldn't pg_dumpall also use DumpOptions?
- What about binary_upgrade?
- I think some of the variables in pg_dump's main() don't need to
On 8/15/14 7:30 PM, Joachim Wieland wrote:
> Attached is a patch that doesn't add any new functionality or
> features, all it does is get rid of the global variables that
> pg_dump.c is full of.
I'm getting a compiler error:
In file included from pg_dump.c:60:
In file included from ./pg_backup_ar
On 08/19/2014 01:40 AM, Robert Haas wrote:
>> > Attached is a patch that doesn't add any new functionality or
>> > features, all it does is get rid of the global variables that
>> > pg_dump.c is full of.
> I think this is an excellent idea.
It's also one small step toward library-ifying pg_dump.
On Fri, Aug 15, 2014 at 7:30 PM, Joachim Wieland wrote:
> Attached is a patch that doesn't add any new functionality or
> features, all it does is get rid of the global variables that
> pg_dump.c is full of.
I think this is an excellent idea.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb
13 matches
Mail list logo
