Re: [HACKERS] pg_hba options parsing

2008-10-23 Thread Magnus Hagander
Magnus Hagander wrote: This patch changes the options field of pg_hba.conf to take name/value pairs instead of a fixed string. This makes it a lot nicer to deal with auth methods that need more than one parameter, such as LDAP. While at it, it also adds map support to kerberos, gssapi and

Re: [HACKERS] pg_hba options parsing

2008-10-20 Thread Magnus Hagander
Bruce Momjian wrote: OK, a few comments: This should have spaces: !port-hba-ldapprefix?port-hba-ldapprefix:, Fixed. Though I guess pgindent would've fixed it eventually otherwise. This is missing 'do' or something: + #define MANDATORY_AUTH_ARG(argvar, argname,

Re: [HACKERS] pg_hba options parsing

2008-10-20 Thread Tom Lane
Magnus Hagander [EMAIL PROTECTED] writes: Bruce Momjian wrote: This is missing 'do' or something: + #define MANDATORY_AUTH_ARG(argvar, argname, authname) \ + if (argvar == NULL) {\ + ereport(LOG, \ + (errcode(ERRCODE_CONFIG_FILE_ERROR), \ +errmsg(authentication

Re: [HACKERS] pg_hba options parsing

2008-10-20 Thread Magnus Hagander
Tom Lane wrote: Magnus Hagander [EMAIL PROTECTED] writes: Bruce Momjian wrote: This is missing 'do' or something: + #define MANDATORY_AUTH_ARG(argvar, argname, authname) \ + if (argvar == NULL) {\ + ereport(LOG, \ + (errcode(ERRCODE_CONFIG_FILE_ERROR), \ +

Re: [HACKERS] pg_hba options parsing

2008-10-11 Thread Magnus Hagander
Magnus Hagander wrote: This patch changes the options field of pg_hba.conf to take name/value pairs instead of a fixed string. This makes it a lot nicer to deal with auth methods that need more than one parameter, such as LDAP. While at it, it also adds map support to kerberos, gssapi and

[HACKERS] pg_hba options parsing

2008-09-30 Thread Magnus Hagander
This patch changes the options field of pg_hba.conf to take name/value pairs instead of a fixed string. This makes it a lot nicer to deal with auth methods that need more than one parameter, such as LDAP. While at it, it also adds map support to kerberos, gssapi and sspi and not just ident -