Re: [HACKERS] pg_replication_origin_xact_reset() and its argument variables

2016-08-05 Thread Fujii Masao
On Tue, Aug 2, 2016 at 2:59 AM, Fujii Masao wrote: > On Tue, Aug 2, 2016 at 2:48 AM, Andres Freund wrote: >> Hi Fujii, >> >> On 2016-07-28 16:44:37 +0900, Fujii Masao wrote: >>> On Sat, Jul 2, 2016 at 7:01 AM, Tom Lane wrote: >>> >

Re: [HACKERS] pg_replication_origin_xact_reset() and its argument variables

2016-08-01 Thread Fujii Masao
On Tue, Aug 2, 2016 at 2:48 AM, Andres Freund wrote: > Hi Fujii, > > On 2016-07-28 16:44:37 +0900, Fujii Masao wrote: >> On Sat, Jul 2, 2016 at 7:01 AM, Tom Lane wrote: >> > Andres Freund writes: >> >> On 2016-06-30 10:14:04 -0400, Tom

Re: [HACKERS] pg_replication_origin_xact_reset() and its argument variables

2016-08-01 Thread Andres Freund
Hi Fujii, On 2016-07-28 16:44:37 +0900, Fujii Masao wrote: > On Sat, Jul 2, 2016 at 7:01 AM, Tom Lane wrote: > > Andres Freund writes: > >> On 2016-06-30 10:14:04 -0400, Tom Lane wrote: > >>> Fujii Masao writes: > As far as I

Re: [HACKERS] pg_replication_origin_xact_reset() and its argument variables

2016-08-01 Thread Andres Freund
On 2016-07-28 16:44:37 +0900, Fujii Masao wrote: > diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml > index d6ed0ce..0a3d3de 100644 > --- a/doc/src/sgml/func.sgml > +++ b/doc/src/sgml/func.sgml > @@ -17519,7 +17519,7 @@ postgres=# SELECT * FROM >

Re: [HACKERS] pg_replication_origin_xact_reset() and its argument variables

2016-08-01 Thread Robert Haas
On Thu, Jul 28, 2016 at 3:44 AM, Fujii Masao wrote: Sure looks that way from here. Copy-and-paste from the previous line in pg_proc.h, perhaps? >> >>> Yes, that's clearly wrong. > > Attached patch (pg_replication_origin_xact_reset_9.6.patch) fixes this. > We need

Re: [HACKERS] pg_replication_origin_xact_reset() and its argument variables

2016-07-28 Thread Fujii Masao
On Sat, Jul 2, 2016 at 7:01 AM, Tom Lane wrote: > Andres Freund writes: >> On 2016-06-30 10:14:04 -0400, Tom Lane wrote: >>> Fujii Masao writes: As far as I read the code of the function, those arguments don't seem to be

Re: [HACKERS] pg_replication_origin_xact_reset() and its argument variables

2016-07-01 Thread Tom Lane
Andres Freund writes: > On 2016-06-30 10:14:04 -0400, Tom Lane wrote: >> Fujii Masao writes: >>> As far as I read the code of the function, those arguments don't seem to >>> be necessary. So I'm afraid that the pg_proc entry for the function might >>>

Re: [HACKERS] pg_replication_origin_xact_reset() and its argument variables

2016-07-01 Thread Andres Freund
On 2016-06-30 10:14:04 -0400, Tom Lane wrote: > Fujii Masao writes: > > The document explains that pg_replication_origin_xact_reset() doesn't have > > any argument variables. But it's been actually defined so as to have two > > argument variables with pg_lsn and timestamptz

Re: [HACKERS] pg_replication_origin_xact_reset() and its argument variables

2016-06-30 Thread Tom Lane
Fujii Masao writes: > The document explains that pg_replication_origin_xact_reset() doesn't have > any argument variables. But it's been actually defined so as to have two > argument variables with pg_lsn and timestamptz data types, as follows. > =# \df

[HACKERS] pg_replication_origin_xact_reset() and its argument variables

2016-06-30 Thread Fujii Masao
Hi, The document explains that pg_replication_origin_xact_reset() doesn't have any argument variables. But it's been actually defined so as to have two argument variables with pg_lsn and timestamptz data types, as follows. =# \df pg_replication_origin_xact_reset