Re: [HACKERS] pg_rewind hangs if --source-server is used and syncrep is enabled

2016-10-06 Thread Michael Paquier
On Thu, Oct 6, 2016 at 7:37 PM, Heikki Linnakangas wrote: > Committed, thanks! I moved the call to where we establish the connection, > that felt slightly more natural. Thanks for the commit. Indeed that's better with the other sanity checks. -- Michael -- Sent via

Re: [HACKERS] pg_rewind hangs if --source-server is used and syncrep is enabled

2016-10-06 Thread Heikki Linnakangas
On 10/06/2016 02:24 AM, Michael Paquier wrote: On Wed, Oct 5, 2016 at 11:53 PM, Michael Banck wrote: My colleague Christoph Berg pointed out that pg_rewind could just set synchronous_commit = local before creating the temporary table, which indeed works,

Re: [HACKERS] pg_rewind hangs if --source-server is used and syncrep is enabled

2016-10-05 Thread Michael Paquier
On Wed, Oct 5, 2016 at 11:53 PM, Michael Banck wrote: > On Wed, Oct 05, 2016 at 04:39:39PM +0200, Michael Banck wrote: >> To the user, the last thing printed is "need to copy MB [...]". If >> the user cancels the pg_rewind command with ^C, the backend keeps >>

Re: [HACKERS] pg_rewind hangs if --source-server is used and syncrep is enabled

2016-10-05 Thread Michael Banck
On Wed, Oct 05, 2016 at 04:39:39PM +0200, Michael Banck wrote: > if pg_rewind is told to fetch data via a libpq connection > (--source-server), synchronous replication is enabled and there is only > one sync standby (pilot error, but sill); pg_rewinding the old master > hangs at the CREATE

[HACKERS] pg_rewind hangs if --source-server is used and syncrep is enabled

2016-10-05 Thread Michael Banck
Hi, if pg_rewind is told to fetch data via a libpq connection (--source-server), synchronous replication is enabled and there is only one sync standby (pilot error, but sill); pg_rewinding the old master hangs at the CREATE TEMPORARY TABLE step (CREATE TABLE waiting for X/). At least