Re: [HACKERS] pg_rewind test race condition..?

2016-03-26 Thread Michael Paquier
On Wed, Apr 29, 2015 at 10:03 PM, Stephen Frost wrote: > Another thought would be to provide an option to pg_rewind to have it do > an explicit checkpoint before it reads the control file.. I'm not > against having it simply always do it as I don't see pg_rewind being a >

Re: [HACKERS] pg_rewind test race condition..?

2015-12-08 Thread Oleksii Kliukin
Hi, On Wed, Apr 29, 2015, at 01:36 AM, Heikki Linnakangas wrote: > The problem seems to be that when the standby is promoted, it's a > so-called "fast promotion", where it writes an end-of-recovery record > and starts accepting queries before creating a real checkpoint. > pg_rewind looks at

Re: [HACKERS] pg_rewind test race condition..?

2015-05-01 Thread Stephen Frost
Heikki, * Heikki Linnakangas (hlinn...@iki.fi) wrote: On 04/29/2015 06:03 AM, Stephen Frost wrote: Forcing a checkpoint in the regression tests and then providing a better error message sounds reasonable to me. I agree that it's very unlikely to happen in the real world, even when you're

Re: [HACKERS] pg_rewind test race condition..?

2015-04-30 Thread Heikki Linnakangas
On 04/29/2015 06:03 AM, Stephen Frost wrote: * Heikki Linnakangas (hlinn...@iki.fi) wrote: --- a/src/backend/access/transam/xlog.c +++ b/src/backend/access/transam/xlog.c @@ -7173,7 +7173,10 @@ StartupXLOG(void) * than is appropriate now that we're not in standby mode anymore.

Re: [HACKERS] pg_rewind test race condition..?

2015-04-29 Thread Stephen Frost
Heikki, * Heikki Linnakangas (hlinn...@iki.fi) wrote: The problem seems to be that when the standby is promoted, it's a so-called fast promotion, where it writes an end-of-recovery record and starts accepting queries before creating a real checkpoint. pg_rewind looks at the TLI in the latest

Re: [HACKERS] pg_rewind test race condition..?

2015-04-28 Thread Heikki Linnakangas
On 04/28/2015 11:02 AM, Stephen Frost wrote: Heikki, Not sure if anyone else is seeing this, but I'm getting regression test failures when running the pg_rewind tests pretty consistently with 'make check'. Specifically with basic remote, I'm getting: source and target cluster are on

[HACKERS] pg_rewind test race condition..?

2015-04-28 Thread Stephen Frost
Heikki, Not sure if anyone else is seeing this, but I'm getting regression test failures when running the pg_rewind tests pretty consistently with 'make check'. Specifically with basic remote, I'm getting: source and target cluster are on the same timeline Failure, exiting in