Re: [HACKERS] pg_rewind tests

2015-04-13 Thread Michael Paquier
On Tue, Apr 14, 2015 at 12:32 AM, Heikki Linnakangas wrote: > Applied, thanks! Thanks. Now, for Windows... -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pg_rewind tests

2015-04-13 Thread Heikki Linnakangas
On 04/02/2015 04:56 AM, Michael Paquier wrote: On Tue, Mar 31, 2015 at 4:37 PM, Michael Paquier wrote: While looking at that I noticed two additional issues: - In remote mode, the connection string to the promoted standby was incorrect when running pg_rewind, leading to connection errors - At

Re: [HACKERS] pg_rewind tests

2015-04-13 Thread Heikki Linnakangas
On 04/10/2015 04:01 PM, Alvaro Herrera wrote: Do these tests work in VPATH builds? I now get a failure in "make check-world" (both with and without Michael's patch). "make check" in src/bin/pg_rewind dies with the output below. If I change "./pg_rewind" to "pg_rewind", tests pass, but I wonder

Re: [HACKERS] pg_rewind tests

2015-04-01 Thread Michael Paquier
On Tue, Mar 31, 2015 at 4:37 PM, Michael Paquier wrote: > While looking at that I noticed two additional issues: > - In remote mode, the connection string to the promoted standby was > incorrect when running pg_rewind, leading to connection errors > - At least in my environment, a sleep of 1 afte

Re: [HACKERS] pg_rewind tests

2015-03-31 Thread Michael Paquier
On Tue, Mar 31, 2015 at 9:59 AM, Peter Eisentraut wrote: > There are some small issues with the pg_rewind tests. > > This technique > > check: all > $(prove_check) :: local > $(prove_check) :: remote > > for passing arguments to "prove" does not work with the tools included > in P

[HACKERS] pg_rewind tests

2015-03-30 Thread Peter Eisentraut
There are some small issues with the pg_rewind tests. This technique check: all $(prove_check) :: local $(prove_check) :: remote for passing arguments to "prove" does not work with the tools included in Perl 5.8. While sorting out the portability issues in the TAP framework duri