Re: [HACKERS] pg_serial early wraparound

2017-09-01 Thread Thomas Munro
On Wed, Jun 28, 2017 at 1:11 PM, Thomas Munro wrote: > On Sat, Mar 25, 2017 at 7:27 AM, Thomas Munro > wrote: >> On Sat, Mar 25, 2017 at 3:11 AM, Anastasia Lubennikova >> wrote: >>> You claim that SLRUs now

Re: [HACKERS] pg_serial early wraparound

2017-06-27 Thread Thomas Munro
On Sat, Mar 25, 2017 at 7:27 AM, Thomas Munro wrote: > On Sat, Mar 25, 2017 at 3:11 AM, Anastasia Lubennikova > wrote: >> You claim that SLRUs now support five digit segment name, while in slru.h >> at current master I see the following: >>

Re: [HACKERS] pg_serial early wraparound

2017-03-24 Thread Thomas Munro
On Sat, Mar 25, 2017 at 3:11 AM, Anastasia Lubennikova wrote: > Hi, I've tried to review this patch, but it seems that I miss something > essential. Hi Anastasia, Thanks for looking at this. > You claim that SLRUs now support five digit segment name, while in slru.h >

Re: [HACKERS] pg_serial early wraparound

2017-03-24 Thread Anastasia Lubennikova
The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:not tested Hi, I've tried to review this patch, but it seems that I miss something

Re: [HACKERS] pg_serial early wraparound

2017-02-26 Thread Thomas Munro
On Mon, Feb 27, 2017 at 7:28 PM, Thomas Munro wrote: > On Wed, Nov 9, 2016 at 11:07 AM, Thomas Munro > wrote: >> The SLRU managed by predicate.c can wrap around and overwrite data if >> you have more than 1 billion active XIDs.

Re: [HACKERS] pg_serial early wraparound

2017-02-26 Thread Thomas Munro
On Wed, Nov 9, 2016 at 11:07 AM, Thomas Munro wrote: > The SLRU managed by predicate.c can wrap around and overwrite data if > you have more than 1 billion active XIDs. That's because when SSI was > implemented, slru.c was limited to four digit segment names, which

[HACKERS] pg_serial early wraparound

2016-11-08 Thread Thomas Munro
Hi hackers, The SLRU managed by predicate.c can wrap around and overwrite data if you have more than 1 billion active XIDs. That's because when SSI was implemented, slru.c was limited to four digit segment names, which implied a page limit that wasn't enough for pg_serial to have space for every