Re: [HACKERS] pg_stat directory and pg_stat_statements

2014-06-19 Thread Shigeru Hanada
Fujii-san, I found the right description in REL9_3_STABLE branch, thanks for pointing out the commit. Sorry for noise. 2014-06-18 12:39 GMT+09:00 Fujii Masao : > On Tue, Jun 17, 2014 at 2:11 PM, Shigeru Hanada > wrote: >> Fujii-san, >> >> I agree not to backpatch, but I noticed that the 9.3 doc

Re: [HACKERS] pg_stat directory and pg_stat_statements

2014-06-17 Thread Fujii Masao
On Tue, Jun 17, 2014 at 2:11 PM, Shigeru Hanada wrote: > Fujii-san, > > I agree not to backpatch, but I noticed that the 9.3 document about > stats collector doesn't mention $PGDATA/pg_stat. > > http://www.postgresql.org/docs/current/static/monitoring-stats.html > > It just says: >> When the serve

Re: [HACKERS] pg_stat directory and pg_stat_statements

2014-06-16 Thread Shigeru Hanada
Fujii-san, I agree not to backpatch, but I noticed that the 9.3 document about stats collector doesn't mention $PGDATA/pg_stat. http://www.postgresql.org/docs/current/static/monitoring-stats.html It just says: > When the server shuts down, a permanent copy of the statistics data is stored > in

Re: [HACKERS] pg_stat directory and pg_stat_statements

2014-06-03 Thread Fujii Masao
On Tue, Jun 3, 2014 at 6:38 PM, Magnus Hagander wrote: > On Mon, Jun 2, 2014 at 4:07 PM, Andres Freund > wrote: >> >> On 2014-06-02 22:59:55 +0900, Fujii Masao wrote: >> > On Thu, May 29, 2014 at 3:02 PM, Peter Geoghegan wrote: >> > > On Wed, May 28, 2014 at 10:49 PM, Fujii Masao >> > > wrote:

Re: [HACKERS] pg_stat directory and pg_stat_statements

2014-06-03 Thread Magnus Hagander
On Mon, Jun 2, 2014 at 4:07 PM, Andres Freund wrote: > On 2014-06-02 22:59:55 +0900, Fujii Masao wrote: > > On Thu, May 29, 2014 at 3:02 PM, Peter Geoghegan wrote: > > > On Wed, May 28, 2014 at 10:49 PM, Fujii Masao > wrote: > > >> You're concerned about the scenario using pg_upgrade? I'm not s

Re: [HACKERS] pg_stat directory and pg_stat_statements

2014-06-02 Thread Michael Paquier
On Mon, Jun 2, 2014 at 11:07 PM, Andres Freund wrote: > On 2014-06-02 22:59:55 +0900, Fujii Masao wrote: >> On Thu, May 29, 2014 at 3:02 PM, Peter Geoghegan wrote: >> > On Wed, May 28, 2014 at 10:49 PM, Fujii Masao >> > wrote: >> >> You're concerned about the scenario using pg_upgrade? I'm not

Re: [HACKERS] pg_stat directory and pg_stat_statements

2014-06-02 Thread Andres Freund
On 2014-06-02 22:59:55 +0900, Fujii Masao wrote: > On Thu, May 29, 2014 at 3:02 PM, Peter Geoghegan wrote: > > On Wed, May 28, 2014 at 10:49 PM, Fujii Masao wrote: > >> You're concerned about the scenario using pg_upgrade? I'm not sure the > >> detail > >> of pg_upgrade. But if it doesn't work p

Re: [HACKERS] pg_stat directory and pg_stat_statements

2014-06-02 Thread Fujii Masao
On Thu, May 29, 2014 at 3:02 PM, Peter Geoghegan wrote: > On Wed, May 28, 2014 at 10:49 PM, Fujii Masao wrote: >> You're concerned about the scenario using pg_upgrade? I'm not sure the detail >> of pg_upgrade. But if it doesn't work properly, we should have gotten >> the trouble > > I'm not worri

Re: [HACKERS] pg_stat directory and pg_stat_statements

2014-05-28 Thread Ashesh Vashi
On Thu, May 29, 2014 at 11:32 AM, Peter Geoghegan wrote: > On Wed, May 28, 2014 at 10:49 PM, Fujii Masao > wrote: > > You're concerned about the scenario using pg_upgrade? > Yeah - I was. > I'm not sure the detail > > of pg_upgrade. But if it doesn't work properly, we should have gotten > > th

Re: [HACKERS] pg_stat directory and pg_stat_statements

2014-05-28 Thread Peter Geoghegan
On Wed, May 28, 2014 at 10:49 PM, Fujii Masao wrote: > You're concerned about the scenario using pg_upgrade? I'm not sure the detail > of pg_upgrade. But if it doesn't work properly, we should have gotten > the trouble I'm not worried about pg_upgrade, because by design pg_stat_statements will di

Re: [HACKERS] pg_stat directory and pg_stat_statements

2014-05-28 Thread Fujii Masao
On Thu, May 29, 2014 at 1:01 PM, Ashesh Vashi wrote: > On Thu, May 29, 2014 at 8:52 AM, Fujii Masao wrote: >> >> On Thu, May 29, 2014 at 4:55 AM, Tomas Vondra wrote: >> > On 28.5.2014 19:52, Fujii Masao wrote: >> >> On Thu, May 29, 2014 at 12:37 AM, Peter Geoghegan >> >> wrote: >> >>> On Wed, M

Re: [HACKERS] pg_stat directory and pg_stat_statements

2014-05-28 Thread Ashesh Vashi
On Thu, May 29, 2014 at 8:52 AM, Fujii Masao wrote: > On Thu, May 29, 2014 at 4:55 AM, Tomas Vondra wrote: > > On 28.5.2014 19:52, Fujii Masao wrote: > >> On Thu, May 29, 2014 at 12:37 AM, Peter Geoghegan > wrote: > >>> On Wed, May 28, 2014 at 7:01 AM, Fujii Masao > wrote: > But pg_stat_s

Re: [HACKERS] pg_stat directory and pg_stat_statements

2014-05-28 Thread Fujii Masao
On Thu, May 29, 2014 at 4:55 AM, Tomas Vondra wrote: > On 28.5.2014 19:52, Fujii Masao wrote: >> On Thu, May 29, 2014 at 12:37 AM, Peter Geoghegan wrote: >>> On Wed, May 28, 2014 at 7:01 AM, Fujii Masao wrote: But pg_stat_statements file is saved under $PGDATA/global yet. Is this inten

Re: [HACKERS] pg_stat directory and pg_stat_statements

2014-05-28 Thread Tomas Vondra
On 28.5.2014 19:52, Fujii Masao wrote: > On Thu, May 29, 2014 at 12:37 AM, Peter Geoghegan wrote: >> On Wed, May 28, 2014 at 7:01 AM, Fujii Masao wrote: >>> But pg_stat_statements file is saved under $PGDATA/global yet. >>> Is this intentional or just oversight? >> >> >> I think it's an oversight

Re: [HACKERS] pg_stat directory and pg_stat_statements

2014-05-28 Thread Fujii Masao
On Thu, May 29, 2014 at 12:37 AM, Peter Geoghegan wrote: > On Wed, May 28, 2014 at 7:01 AM, Fujii Masao wrote: >> But pg_stat_statements file is saved under $PGDATA/global yet. >> Is this intentional or just oversight? > > > I think it's an oversight. OK, patch attached. I'm afraid that it's no

Re: [HACKERS] pg_stat directory and pg_stat_statements

2014-05-28 Thread Peter Geoghegan
On Wed, May 28, 2014 at 7:01 AM, Fujii Masao wrote: > But pg_stat_statements file is saved under $PGDATA/global yet. > Is this intentional or just oversight? I think it's an oversight. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes t

[HACKERS] pg_stat directory and pg_stat_statements

2014-05-28 Thread Fujii Masao
Hi, Thanks to 187492b6c2e8cafc5b39063ca3b67846e8155d24, pgstat files are now saved to $PGDATA/pg_stat directory at shutdown. But pg_stat_statements file is saved under $PGDATA/global yet. Is this intentional or just oversight? Saving that file to global is harmless, though. Regards, -- Fujii Ma