On 08/24/2012 11:44 AM, Alvaro Herrera wrote:
Again, win32 testing would be welcome. Sadly, buildfarm does not run
pg_upgrade's make check.
Yesterday I added a new module to the buildfarm client code to run this
On 08/31/2012 10:52 AM, Andrew Dunstan wrote:
On 08/24/2012 11:44 AM, Alvaro Herrera wrote:
Again, win32 testing would be welcome. Sadly, buildfarm does not run
pg_upgrade's make check.
Yesterday I added a new module to the buildfarm client code to run
this
Excerpts from Alvaro Herrera's message of vie ago 24 11:44:33 -0400 2012:
Actually it seems better to just get rid of the extra varargs function
and just have a single exec_prog. The extra NULL argument is not
troublesome enough, it seems. Updated version attached.
Applied (with some very
On 23.08.2012 23:07, Alvaro Herrera wrote:
One problem with this is that I get this warning:
/pgsql/source/HEAD/contrib/pg_upgrade/exec.c: In function ‘s_exec_prog’:
/pgsql/source/HEAD/contrib/pg_upgrade/exec.c:96:2: warning: function might be
possible candidate for ‘gnu_printf’ format
Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes:
On 23.08.2012 23:07, Alvaro Herrera wrote:
One problem with this is that I get this warning:
/pgsql/source/HEAD/contrib/pg_upgrade/exec.c: In function âs_exec_progâ:
/pgsql/source/HEAD/contrib/pg_upgrade/exec.c:96:2: warning:
On Fri, Aug 24, 2012 at 10:08:58AM -0400, Tom Lane wrote:
Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes:
On 23.08.2012 23:07, Alvaro Herrera wrote:
One problem with this is that I get this warning:
/pgsql/source/HEAD/contrib/pg_upgrade/exec.c: In function ‘s_exec_prog’:
Bruce Momjian br...@momjian.us writes:
It sounds like it is suggestioning to use more specific attribute
decoration. This might be relevant:
http://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html
-Wmissing-format-attribute
Warn about function pointers that
Actually it seems better to just get rid of the extra varargs function
and just have a single exec_prog. The extra NULL argument is not
troublesome enough, it seems. Updated version attached.
Again, win32 testing would be welcome. Sadly, buildfarm does not run
pg_upgrade's make check.
--
On Fri, 2012-08-24 at 10:08 -0400, Tom Lane wrote:
Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes:
On 23.08.2012 23:07, Alvaro Herrera wrote:
One problem with this is that I get this warning:
/pgsql/source/HEAD/contrib/pg_upgrade/exec.c: In function ‘s_exec_prog’:
Hi,
I've been bitten twice by exec_prog()s API, so here's a patch to try to
make it a bit harder to misuse.
There are two main changes here; one is to put the logfile option as the
first argument; then comes a bool, then the format string. This means
you get a warning if you pass the wrong
10 matches
Mail list logo