On Thu, Jan 30, 2014 at 11:44:31PM -0500, Tom Lane wrote:
Bruce Momjian br...@momjian.us writes:
OK, seven hours later, I have fixed pg_bsd_indent to no longer insert
blank lines above #elif/#else/#endif, and therefore removed the special
case code from pgindent.
You will need to
On Fri, Jan 31, 2014 at 11:18:17AM -0500, Bruce Momjian wrote:
Yes, it is a shame pgindent has removed many proper empty lines in the
past and there is no way to re-add them without causing backpatching
problems.
FYI, the original BSD indent code that added the blank lines kind of
made sense.
On Thu, Jul 18, 2013 at 12:27:21AM -0400, Tom Lane wrote:
It's always annoyed me that pgindent insists on adjusting vertical
whitespace around #else and related commands. This has, for example,
rendered src/include/storage/barrier.h nigh illegible: you get things
like
/*
* lwsync orders
Bruce Momjian br...@momjian.us writes:
On Thu, Jul 18, 2013 at 12:27:21AM -0400, Tom Lane wrote:
I assert that we should simply remove both of these bits of code, as
just about every committer on the project is smarter about when to use
vertical whitespace than this program is.
OK, I have
On Thu, Jan 30, 2014 at 01:46:34PM -0500, Tom Lane wrote:
Bruce Momjian br...@momjian.us writes:
On Thu, Jul 18, 2013 at 12:27:21AM -0400, Tom Lane wrote:
I assert that we should simply remove both of these bits of code, as
just about every committer on the project is smarter about when to
On Thu, Jan 30, 2014 at 01:52:55PM -0500, Bruce Momjian wrote:
On Thu, Jan 30, 2014 at 01:46:34PM -0500, Tom Lane wrote:
Bruce Momjian br...@momjian.us writes:
On Thu, Jul 18, 2013 at 12:27:21AM -0400, Tom Lane wrote:
I assert that we should simply remove both of these bits of code, as
Bruce Momjian br...@momjian.us writes:
OK, seven hours later, I have fixed pg_bsd_indent to no longer insert
blank lines above #elif/#else/#endif, and therefore removed the special
case code from pgindent.
You will need to download version 1.3 of pg_bsd_indent for this to work,
and pgindent
On 07/18/2013 11:30 PM, Tom Lane wrote:
Noah Misch n...@leadboat.com writes:
On Thu, Jul 18, 2013 at 12:27:21AM -0400, Tom Lane wrote:
It's always annoyed me that pgindent insists on adjusting vertical
whitespace around #else and related commands. This has, for example,
rendered
On Thu, Jul 18, 2013 at 12:27:21AM -0400, Tom Lane wrote:
It's always annoyed me that pgindent insists on adjusting vertical
whitespace around #else and related commands. This has, for example,
rendered src/include/storage/barrier.h nigh illegible: you get things
like
/*
* lwsync orders
On Thu, Jul 18, 2013 at 12:27:21AM -0400, Tom Lane wrote:
It's always annoyed me that pgindent insists on adjusting vertical
whitespace around #else and related commands. This has, for example,
rendered src/include/storage/barrier.h nigh illegible: you get things
like
/*
* lwsync orders
Noah Misch n...@leadboat.com writes:
On Thu, Jul 18, 2013 at 12:27:21AM -0400, Tom Lane wrote:
It's always annoyed me that pgindent insists on adjusting vertical
whitespace around #else and related commands. This has, for example,
rendered src/include/storage/barrier.h nigh illegible: you get
It's always annoyed me that pgindent insists on adjusting vertical
whitespace around #else and related commands. This has, for example,
rendered src/include/storage/barrier.h nigh illegible: you get things
like
/*
* lwsync orders loads with respect to each other, and similarly with stores.
*
12 matches
Mail list logo
