Re: [HACKERS] pgsql crollable cursor doesn't support one form of postgresql's cu

2007-04-26 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. ---

Re: [HACKERS] pgsql crollable cursor doesn't support one form of postgresql's cu

2007-04-26 Thread Neil Conway
I haven't read the rest of the thread yet, but is this hunk not buggy? yylex() is side-effecting, so the two calls to yylex() do not do what the comment suggests. *** 2083,2091 check_FROM = false; } ! /* check FROM keyword after direction's specification */ !

Re: [HACKERS] pgsql crollable cursor doesn't support one form of postgresql's cu

2007-04-19 Thread Pavel Stehule
Pavel Stehule [EMAIL PROTECTED] writes: I found one unsupported form plpgsql's fetch statement which is supported by postgresql. PostgreSQL knows FETCH 3 FROM but plpgsql needs everytime direction's keyword. No, I think that's OK, because that form specifies fetching 3 rows,