Re: [HACKERS] plperl message style on newly added messages

2010-02-15 Thread Tom Lane
Robert Haas writes: > On Mon, Feb 15, 2010 at 10:02 AM, Alvaro Herrera > wrote: >> I notice that the new plperl error messages are somewhat out of line of >> our usual style: >> >>            ereport(ERROR, >>                    (errcode(ERRCODE_INTERNAL_ERROR), >>                        errmsg(

Re: [HACKERS] plperl message style on newly added messages

2010-02-15 Thread Robert Haas
On Mon, Feb 15, 2010 at 10:02 AM, Alvaro Herrera wrote: > I notice that the new plperl error messages are somewhat out of line of > our usual style: > >            ereport(ERROR, >                    (errcode(ERRCODE_INTERNAL_ERROR), >                        errmsg("while executing utf8fix"), >  

[HACKERS] plperl message style on newly added messages

2010-02-15 Thread Alvaro Herrera
Hi, I notice that the new plperl error messages are somewhat out of line of our usual style: ereport(ERROR, (errcode(ERRCODE_INTERNAL_ERROR), errmsg("while executing utf8fix"), errdetail("%s", strip_trailing_ws(SvPV_n