Re: [HACKERS] postgresql.auto.conf comments

2014-11-24 Thread Amit Kapila
On Tue, Nov 25, 2014 at 1:56 AM, Thom Brown wrote: > > Hi, > > I haven't seen this mentioned anywhere (although it may have as I haven't read through the entire history of it), but would others find it useful to have ALTER SYSTEM support comments? > > e.g. > > ALTER SYSTEM SET autovacuum_vacuum_sc

Re: [HACKERS] postgresql.auto.conf comments

2014-11-24 Thread Stephen Frost
* Robert Haas (robertmh...@gmail.com) wrote: > On Mon, Nov 24, 2014 at 4:22 PM, Thom Brown wrote: > > Perhaps the parser could automatically remove any comment blocks which are > > followed by a blank/empty line. > > Well, if we can agree on something, it doesn't bother me any. I'm > just saying

Re: [HACKERS] postgresql.auto.conf comments

2014-11-24 Thread Stephen Frost
* Thom Brown (t...@linux.com) wrote: > On 24 November 2014 at 20:40, Stephen Frost wrote: > > I will point out that this use of COMMENT is novel though, no? Comments > > are normally handled as "COMMENT ON blah IS 'whatever';" ALTER SYSTEM > > is certainly special but I'm not sure I like the ide

Re: [HACKERS] postgresql.auto.conf comments

2014-11-24 Thread Robert Haas
On Mon, Nov 24, 2014 at 4:22 PM, Thom Brown wrote: > Perhaps the parser could automatically remove any comment blocks which are > followed by a blank/empty line. Well, if we can agree on something, it doesn't bother me any. I'm just saying we spent years arguing about it, because we couldn't agr

Re: [HACKERS] postgresql.auto.conf comments

2014-11-24 Thread Thom Brown
On 24 November 2014 at 21:04, Robert Haas wrote: > On Mon, Nov 24, 2014 at 3:26 PM, Thom Brown wrote: > > I haven't seen this mentioned anywhere (although it may have as I haven't > > read through the entire history of it), but would others find it useful > to > > have ALTER SYSTEM support comme

Re: [HACKERS] postgresql.auto.conf comments

2014-11-24 Thread Robert Haas
On Mon, Nov 24, 2014 at 3:26 PM, Thom Brown wrote: > I haven't seen this mentioned anywhere (although it may have as I haven't > read through the entire history of it), but would others find it useful to > have ALTER SYSTEM support comments? Oh, please no. The main thing that caused us to have n

Re: [HACKERS] postgresql.auto.conf comments

2014-11-24 Thread Thom Brown
On 24 November 2014 at 20:40, Stephen Frost wrote: > * Thom Brown (t...@linux.com) wrote: > > I haven't seen this mentioned anywhere (although it may have as I haven't > > read through the entire history of it), but would others find it useful > to > > have ALTER SYSTEM support comments? > > I do

Re: [HACKERS] postgresql.auto.conf comments

2014-11-24 Thread Stephen Frost
* Thom Brown (t...@linux.com) wrote: > I haven't seen this mentioned anywhere (although it may have as I haven't > read through the entire history of it), but would others find it useful to > have ALTER SYSTEM support comments? I do think it'd be useful. I don't think 'inline' deserves inclusion

[HACKERS] postgresql.auto.conf comments

2014-11-24 Thread Thom Brown
Hi, I haven't seen this mentioned anywhere (although it may have as I haven't read through the entire history of it), but would others find it useful to have ALTER SYSTEM support comments? e.g. ALTER SYSTEM SET autovacuum_vacuum_scale_factor = 0.01 WITH [ INLINE | HEADLINE ] COMMENT $$As most of