Correct Fabien. I have already removed myself as a reviewer. Thanks.
As you wish!
Thanks for the feedback, which I understood as "works for me".
--
Fabien.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/
Correct Fabien. I have already removed myself as a reviewer. Thanks.
-
robins | mobile
On 20 Sep. 2017 5:13 pm, "Fabien COELHO" wrote:
>
> Hello Robins,
>
> I was able to test the functionality (which seemed to work fine) and fed in
>> my comment to assist anyone else reviewing this patch (and
Hello Robins,
I was able to test the functionality (which seemed to work fine) and fed in
my comment to assist anyone else reviewing this patch (and intentionally
let it's state as 'Needs Review').
While trying to provide my feedback, on hindsight I should have been more
detailed about what I
I was able to test the functionality (which seemed to work fine) and fed in my
comment to assist anyone else reviewing this patch (and intentionally let it's
state as 'Needs Review').
While trying to provide my feedback, on hindsight I should have been more
detailed about what I didn't test. Be
Hi Fabien,
I was able to test the functionality (which seemed to work fine) and fed in
my comment to assist anyone else reviewing this patch (and intentionally
let it's state as 'Needs Review').
While trying to provide my feedback, on hindsight I should have been more
detailed about what I didn't
Hello Robins,
Thanks for the review.
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: tested, failed
Where ?
Spec compliant: not tested
Documentation:tested, failed
Where ? I just
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: tested, failed
Spec compliant: not tested
Documentation:tested, failed
The patch applies cleanly and compiles + installs fine (although am u
Here is a version with the :{?varname} syntax.
It looks much better for me.
I'll admit that it looks better to me as well:-)
--
Fabien.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hack
On Sat, Aug 26, 2017 at 2:09 PM, Pavel Stehule
wrote:
>
>
> 2017-08-26 19:55 GMT+02:00 Fabien COELHO :
>
>>
>> Any colon prefixed syntax can be made to work because it is enough for
>>> the lexer to detect and handle... so
>>>
>>> :{defined varname}
>>>
>>> may be an option, although I do not li
2017-08-26 19:55 GMT+02:00 Fabien COELHO :
>
> Any colon prefixed syntax can be made to work because it is enough for the
>> lexer to detect and handle... so
>>
>> :{defined varname}
>>
>> may be an option, although I do not like the space much because it adds
>> some fuzzyness in the lexer which
Any colon prefixed syntax can be made to work because it is enough for the
lexer to detect and handle... so
:{defined varname}
may be an option, although I do not like the space much because it adds some
fuzzyness in the lexer which has to process it. It is probably doable,
though. I like
Hello Pavel,
As a follow-up to the \if patch by Corey Huinker, here is a proposal to
allow testing whether a client-side variable exists in psql.
The syntax is as ugly as the current :'var' and :"var" things, but ISTM
that this is the only simple option to have a working SQL-compatible syntax
2017-08-26 8:54 GMT+02:00 Fabien COELHO :
>
> Hello,
>
> As a follow-up to the \if patch by Corey Huinker, here is a proposal to
> allow testing whether a client-side variable exists in psql.
>
> The syntax is as ugly as the current :'var' and :"var" things, but ISTM
> that this is the only simple
Hello,
As a follow-up to the \if patch by Corey Huinker, here is a proposal to
allow testing whether a client-side variable exists in psql.
The syntax is as ugly as the current :'var' and :"var" things, but ISTM
that this is the only simple option to have a working SQL-compatible
syntax wit
14 matches
Mail list logo
