Re: [HACKERS] psql case preserving completion

2012-02-07 Thread Bruce Momjian
On Wed, Feb 01, 2012 at 08:19:24PM +0200, Peter Eisentraut wrote: On tis, 2012-01-17 at 16:46 +0900, Fujii Masao wrote: When I tested the patch, create ta was converted unexpectedly to create TABLE though alter ta was successfully converted to alter table. As far as I read the patch,

Re: [HACKERS] psql case preserving completion

2012-02-07 Thread Robert Haas
On Tue, Feb 7, 2012 at 8:02 PM, Bruce Momjian br...@momjian.us wrote: On Wed, Feb 01, 2012 at 08:19:24PM +0200, Peter Eisentraut wrote: On tis, 2012-01-17 at 16:46 +0900, Fujii Masao wrote: When I tested the patch, create ta was converted unexpectedly to create TABLE though alter ta was

Re: [HACKERS] psql case preserving completion

2012-02-01 Thread Peter Eisentraut
On tis, 2012-01-17 at 16:46 +0900, Fujii Masao wrote: When I tested the patch, create ta was converted unexpectedly to create TABLE though alter ta was successfully converted to alter table. As far as I read the patch, you seems to have forgotten to change create_or_drop_command_generator()

Re: [HACKERS] psql case preserving completion

2012-01-16 Thread Fujii Masao
On Thu, Jan 12, 2012 at 5:29 AM, Peter Eisentraut pete...@gmx.net wrote: In psql, the tab completion always converts key words to upper case.  In practice, I and I think most users type in lower case.  So then you end up with commands looking like this: = alter TABLE foo add CONSTRAINT bar

[HACKERS] psql case preserving completion

2012-01-11 Thread Peter Eisentraut
In psql, the tab completion always converts key words to upper case. In practice, I and I think most users type in lower case. So then you end up with commands looking like this: = alter TABLE foo add CONSTRAINT bar check (a 0); To address this, I have implemented a slightly different

Re: [HACKERS] psql case preserving completion

2012-01-11 Thread Pavel Stehule
2012/1/11 Peter Eisentraut pete...@gmx.net: In psql, the tab completion always converts key words to upper case.  In practice, I and I think most users type in lower case.  So then you end up with commands looking like this: = alter TABLE foo add CONSTRAINT bar check (a 0); To address