[HACKERS] regression test client encoding

2011-04-15 Thread Peter Eisentraut
Using pg_regress --encoding sets both the server encoding of the test database and the client encoding. (The choice of server encoding is further constrained by locale, but that's a different issue.) Looking at the expected variants of the pesky plpython_unicode test plpython_unicode.out

Re: [HACKERS] regression test client encoding

2011-04-15 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: What I'd suggest is that we take out the bit of code in pg_regress.c that overrides the client encoding. That doesn't seem like a particularly good idea in view of the recent changes in psql to try to intuit a default encoding from its locale

Re: [HACKERS] regression test client encoding

2011-04-15 Thread Peter Eisentraut
On Fri, 2011-04-15 at 16:09 -0400, Tom Lane wrote: Peter Eisentraut pete...@gmx.net writes: What I'd suggest is that we take out the bit of code in pg_regress.c that overrides the client encoding. That doesn't seem like a particularly good idea in view of the recent changes in psql to try

Re: [HACKERS] regression test client encoding

2011-04-15 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: On Fri, 2011-04-15 at 16:09 -0400, Tom Lane wrote: That doesn't seem like a particularly good idea in view of the recent changes in psql to try to intuit a default encoding from its locale environment. If I say --encoding in the command line, that