Re: [HACKERS] remote_apply for logical replication?

2017-01-21 Thread Thomas Munro
On Sun, Jan 22, 2017 at 4:06 AM, Petr Jelinek wrote: > Because we don't have intermediate steps in logical replication, writes > happen immediately and in whole transactions so whatever was received by > the time we send reply is already written (it might not necessarily be > that way forever so t

Re: [HACKERS] remote_apply for logical replication?

2017-01-21 Thread Petr Jelinek
On 21/01/17 01:34, Thomas Munro wrote: > Hi, > > In src/backend/replication/logical/worker.c: > > pq_sendbyte(reply_message, 'r'); > pq_sendint64(reply_message, recvpos); /* write */ > pq_sendint64(reply_message, flushpos); /* flush */ > pq_sendint64(reply_message, wri

[HACKERS] remote_apply for logical replication?

2017-01-20 Thread Thomas Munro
Hi, In src/backend/replication/logical/worker.c: pq_sendbyte(reply_message, 'r'); pq_sendint64(reply_message, recvpos); /* write */ pq_sendint64(reply_message, flushpos); /* flush */ pq_sendint64(reply_message, writepos); /* apply */ Is 'writepos' really applied?