Re: [HACKERS] request for feedback - read-only GUC variables, pg_settings

2003-12-06 Thread Bruce Momjian
Greg Stark wrote: Bruce Momjian [EMAIL PROTECTED] writes: I hate to reply to this because I have already cast my vote, but block_size does not report the size of a disk block. It reports the size of a PostgreSQL block/page. Disk blocks are almost always 512 bytes in size. Perhaps

Re: [HACKERS] request for feedback - read-only GUC variables,

2003-12-05 Thread Josh Berkus
Bruce, Marc, Joe: max_function_args - int Shows the maximum number of function arguments max_index_keys - int Shows the maximum number of index keys Have we decoupled these two variables? Last I checked, their values still had to be identical. If they have not been

Re: [HACKERS] request for feedback - read-only GUC variables,

2003-12-05 Thread Joe Conway
Josh Berkus wrote: max_function_args - int Shows the maximum number of function arguments max_index_keys - int Shows the maximum number of index keys Have we decoupled these two variables? Last I checked, their values still had to be identical. If they have not been decoupled and won't

Re: [HACKERS] request for feedback - read-only GUC variables,

2003-12-05 Thread Tom Lane
Joe Conway [EMAIL PROTECTED] writes: Josh Berkus wrote: Have we decoupled these two variables? Their values are still the same, but Tom suggested we not couple them inextricably by giving users access to them as one variable. The only reason they are the same is that pg_proc.proargtypes and

Re: [HACKERS] request for feedback - read-only GUC variables, pg_settings

2003-12-04 Thread Bruce Momjian
Joe Conway wrote: We (mostly Bruce, Tom, Peter, and I) have been having a discussion on the PATCHES list regarding some new functionality related to read-only GUC variables. The net result is pasted at the bottom of this post. Here is a link to the discussion:

Re: [HACKERS] request for feedback - read-only GUC variables,

2003-12-04 Thread Bruce Momjian
Marc G. Fournier wrote: block_size - int Shows size of a disk block integer_datetimes - bool Datetimes are integer based max_function_args - int Shows the maximum number of function arguments max_identifier_length - int Shows the maximum identifier length

Re: [HACKERS] request for feedback - read-only GUC variables, pg_settings

2003-12-04 Thread Alvaro Herrera
On Thu, Dec 04, 2003 at 06:53:40AM -0500, Bruce Momjian wrote: Joe Conway wrote: The main open question at this point is the name for the block_size variable. Peter favors block_size, Bruce favors page_size, Tom hasn't taken a position on that specific issue. Does anyone have and

Re: [HACKERS] request for feedback - read-only GUC variables,

2003-12-04 Thread Joe Conway
Bruce Momjian wrote: Marc G. Fournier wrote: I'd go with block_size ... True, page size usually references virtual memory pages, so it is related to virtual memory mapping. Block size is much more related to on-disk storage, true. The only reason I was leaning toward page is that it is possible

Re: [HACKERS] request for feedback - read-only GUC variables, pg_settings

2003-12-04 Thread Greg Stark
Bruce Momjian [EMAIL PROTECTED] writes: I hate to reply to this because I have already cast my vote, but block_size does not report the size of a disk block. It reports the size of a PostgreSQL block/page. Disk blocks are almost always 512 bytes in size. Perhaps then neither block nor page

[HACKERS] request for feedback - read-only GUC variables, pg_settings changes

2003-12-02 Thread Joe Conway
We (mostly Bruce, Tom, Peter, and I) have been having a discussion on the PATCHES list regarding some new functionality related to read-only GUC variables. The net result is pasted at the bottom of this post. Here is a link to the discussion:

Re: [HACKERS] request for feedback - read-only GUC variables,

2003-12-02 Thread Marc G. Fournier
On Tue, 2 Dec 2003, Joe Conway wrote: We (mostly Bruce, Tom, Peter, and I) have been having a discussion on the PATCHES list regarding some new functionality related to read-only GUC variables. The net result is pasted at the bottom of this post. Here is a link to the discussion: