Hello
I recheck this patch
1. applied cleanly and compilation was without warnings and errors
2. all tests was passed ok
3. documentation was rebuild without issues
4. I don't see any issue in code quality - it is well commented, well
formatted, with regress tests
It is ready for commit
Here is v2,
with fixed documentation and numeric version of the implementation.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
index f475458..38330d4 100644
---
Hi,
On 21/06/14 20:41, Pavel Stehule wrote:
review: https://commitfest.postgresql.org/action/patch_view?id=1484
Thanks for review.
My comments:
* I miss in documentation description of implementation - its is based
on binary searching, and when second parameter is unsorted array, then
it
2014-06-22 13:02 GMT+02:00 Petr Jelinek p...@2ndquadrant.com:
Hi,
On 21/06/14 20:41, Pavel Stehule wrote:
review: https://commitfest.postgresql.org/action/patch_view?id=1484
Thanks for review.
My comments:
* I miss in documentation description of implementation - its is based
on
Hi,
On 2014-06-21 20:41:43 +0200, Pavel Stehule wrote:
review: https://commitfest.postgresql.org/action/patch_view?id=1484
Can you please not start new threads for reviews of smaller features?
Doing so makes following the discussion much harder. I'm fine with
changing the subject if the reply
review: https://commitfest.postgresql.org/action/patch_view?id=1484
Hello
I did review of this patch, that add three functions varwidth_bucket for
types: anyelement, double and bigint
* This patch respects PostgreSQL coding rules
* it can applied without any issues
* there are no new compile
