Re: [HACKERS] select_parallel test fails with nonstandard block size

2016-09-15 Thread Tom Lane
I wrote: > OK, I'll take care of it (since I now realize that the inconsistency > is my own fault --- I committed that GUC not you). It's unclear what > this will do for Peter's complaint though. On closer inspection, the answer is "nothing", because the select_parallel test overrides the default

Re: [HACKERS] select_parallel test fails with nonstandard block size

2016-09-15 Thread Tom Lane
Robert Haas writes: > On Thu, Sep 15, 2016 at 10:44 AM, Tom Lane wrote: >> Well, sure, but at any reasonable value of min_parallel_relation_size >> that won't be a factor. The question here is whether we want the default >> value to be platform-independent. I notice that both config.sgml and >>

Re: [HACKERS] select_parallel test fails with nonstandard block size

2016-09-15 Thread Robert Haas
On Thu, Sep 15, 2016 at 10:44 AM, Tom Lane wrote: > Robert Haas writes: >> On Thu, Sep 15, 2016 at 9:59 AM, Tom Lane wrote: >>> Possibly we ought to change things so that the default value of >>> min_parallel_relation_size is a fixed number of bytes rather >>> than a fixed number of blocks. Not

Re: [HACKERS] select_parallel test fails with nonstandard block size

2016-09-15 Thread Tom Lane
Robert Haas writes: > On Thu, Sep 15, 2016 at 9:59 AM, Tom Lane wrote: >> Possibly we ought to change things so that the default value of >> min_parallel_relation_size is a fixed number of bytes rather >> than a fixed number of blocks. Not sure though. > The reason why this was originally recko

Re: [HACKERS] select_parallel test fails with nonstandard block size

2016-09-15 Thread Alvaro Herrera
Robert Haas wrote: > On Thu, Sep 15, 2016 at 9:59 AM, Tom Lane wrote: > > Possibly we ought to change things so that the default value of > > min_parallel_relation_size is a fixed number of bytes rather > > than a fixed number of blocks. Not sure though. > > The reason why this was originally re

Re: [HACKERS] select_parallel test fails with nonstandard block size

2016-09-15 Thread Robert Haas
On Thu, Sep 15, 2016 at 9:59 AM, Tom Lane wrote: > Possibly we ought to change things so that the default value of > min_parallel_relation_size is a fixed number of bytes rather > than a fixed number of blocks. Not sure though. The reason why this was originally reckoned in blocks is because the

Re: [HACKERS] select_parallel test fails with nonstandard block size

2016-09-15 Thread Tom Lane
Peter Eisentraut writes: > When building with --with-blocksize=16, the select_parallel test fails > with this difference: > explain (costs off) > select sum(parallel_restricted(unique1)) from tenk1 > group by(parallel_restricted(unique1)); > - QUERY PLAN > --

[HACKERS] select_parallel test fails with nonstandard block size

2016-09-15 Thread Peter Eisentraut
When building with --with-blocksize=16, the select_parallel test fails with this difference: explain (costs off) select sum(parallel_restricted(unique1)) from tenk1 group by(parallel_restricted(unique1)); - QUERY PLAN --